Skip to content

Commit 84c058b

Browse files
author
Tejesh R
committedFeb 16, 2023
8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode
Reviewed-by: aivanov, abhiscxk
1 parent e045af4 commit 84c058b

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed
 

‎src/java.desktop/macosx/classes/com/apple/laf/AquaFileChooserUI.java

+5-2
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ public class AquaFileChooserUI extends FileChooserUI {
162162
protected String filenameTextFieldToolTipText = null;
163163
protected String filterComboBoxToolTipText = null;
164164
protected String openDirectoryButtonToolTipText = null;
165+
protected String chooseButtonToolTipText = null;
165166

166167
protected String cancelOpenButtonToolTipText = null;
167168
protected String cancelSaveButtonToolTipText = null;
@@ -323,6 +324,7 @@ protected void installStrings(final JFileChooser fc) {
323324
// Mac-specific, required
324325
newFolderExistsErrorText = getString("FileChooser.newFolderExistsErrorText", "That name is already taken");
325326
chooseButtonText = getString("FileChooser.chooseButtonText", "Choose");
327+
chooseButtonToolTipText = getString("FileChooser.chooseButtonToolTipText", "Choose selected file");
326328
newFolderButtonText = getString("FileChooser.newFolderButtonText", "New");
327329
newFolderTitleText = getString("FileChooser.newFolderTitleText", "New Folder");
328330

@@ -397,6 +399,7 @@ protected void uninstallStrings(final JFileChooser fc) {
397399
cancelSaveButtonToolTipText = null;
398400
cancelChooseButtonToolTipText = null;
399401
cancelNewFolderButtonToolTipText = null;
402+
chooseButtonToolTipText = null;
400403

401404
saveButtonToolTipText = null;
402405
openButtonToolTipText = null;
@@ -2051,9 +2054,9 @@ int getApproveButtonMnemonic(final JFileChooser fc) {
20512054
return fc.getApproveButtonMnemonic();
20522055
}
20532056

2054-
// No fallback
20552057
String getApproveButtonToolTipText(final JFileChooser fc) {
2056-
return getApproveButtonToolTipText(fc, null);
2058+
// Fallback to "Choose selected file"
2059+
return getApproveButtonToolTipText(fc, chooseButtonToolTipText);
20572060
}
20582061

20592062
String getApproveButtonToolTipText(final JFileChooser fc, final String fallbackText) {

‎src/java.desktop/macosx/classes/com/apple/laf/resources/aqua.properties

+1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ FileChooser.saveTitle.textAndMnemonic=Save
6060
FileChooser.openTitle.textAndMnemonic=Open
6161
FileChooser.newFolderExistsError.textAndMnemonic=That name is already taken
6262
FileChooser.chooseButton.textAndMnemonic=Choose
63+
FileChooser.chooseButtonToolTip.textAndMnemonic=Choose selected file
6364

6465
FileChooser.newFolderButton.textAndMnemonic=New Folder
6566
FileChooser.newFolderTitle.textAndMnemonic=New Folder

0 commit comments

Comments
 (0)
Please sign in to comment.