Skip to content

Commit 623ba5b

Browse files
author
Thomas Schatzl
committedJan 20, 2023
8300653: G1EvacInfo should use common naming scheme for collection set
Reviewed-by: ayang, iwalulya
1 parent 97c611d commit 623ba5b

File tree

4 files changed

+24
-24
lines changed

4 files changed

+24
-24
lines changed
 

‎src/hotspot/share/gc/g1/g1EvacInfo.hpp

+18-18
Original file line numberDiff line numberDiff line change
@@ -28,34 +28,34 @@
2828
#include "memory/allocation.hpp"
2929

3030
class G1EvacInfo : public StackObj {
31-
uint _collectionset_regions;
31+
uint _collection_set_regions;
3232
uint _allocation_regions;
33-
size_t _collectionset_used_before;
34-
size_t _collectionset_used_after;
33+
size_t _collection_set_used_before;
34+
size_t _collection_set_used_after;
3535
size_t _alloc_regions_used_before;
3636
size_t _bytes_used;
3737
uint _regions_freed;
3838

3939
public:
4040
G1EvacInfo() :
41-
_collectionset_regions(0), _allocation_regions(0), _collectionset_used_before(0),
42-
_collectionset_used_after(0), _alloc_regions_used_before(0),
41+
_collection_set_regions(0), _allocation_regions(0), _collection_set_used_before(0),
42+
_collection_set_used_after(0), _alloc_regions_used_before(0),
4343
_bytes_used(0), _regions_freed(0) { }
4444

45-
void set_collectionset_regions(uint collectionset_regions) {
46-
_collectionset_regions = collectionset_regions;
45+
void set_collection_set_regions(uint collection_set_regions) {
46+
_collection_set_regions = collection_set_regions;
4747
}
4848

4949
void set_allocation_regions(uint allocation_regions) {
5050
_allocation_regions = allocation_regions;
5151
}
5252

53-
void set_collectionset_used_before(size_t used) {
54-
_collectionset_used_before = used;
53+
void set_collection_set_used_before(size_t used) {
54+
_collection_set_used_before = used;
5555
}
5656

57-
void increment_collectionset_used_after(size_t used) {
58-
_collectionset_used_after += used;
57+
void increment_collection_set_used_after(size_t used) {
58+
_collection_set_used_after += used;
5959
}
6060

6161
void set_alloc_regions_used_before(size_t used) {
@@ -70,13 +70,13 @@ class G1EvacInfo : public StackObj {
7070
_regions_freed += freed;
7171
}
7272

73-
uint collectionset_regions() { return _collectionset_regions; }
74-
uint allocation_regions() { return _allocation_regions; }
75-
size_t collectionset_used_before() { return _collectionset_used_before; }
76-
size_t collectionset_used_after() { return _collectionset_used_after; }
77-
size_t alloc_regions_used_before() { return _alloc_regions_used_before; }
78-
size_t bytes_used() { return _bytes_used; }
79-
uint regions_freed() { return _regions_freed; }
73+
uint collection_set_regions() { return _collection_set_regions; }
74+
uint allocation_regions() { return _allocation_regions; }
75+
size_t collection_set_used_before() { return _collection_set_used_before; }
76+
size_t collection_set_used_after() { return _collection_set_used_after; }
77+
size_t alloc_regions_used_before() { return _alloc_regions_used_before; }
78+
size_t bytes_used() { return _bytes_used; }
79+
uint regions_freed() { return _regions_freed; }
8080
};
8181

8282
#endif // SHARE_GC_G1_G1EVACINFO_HPP

‎src/hotspot/share/gc/g1/g1Trace.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ void G1NewTracer::send_evacuation_info_event(G1EvacInfo* info) {
145145
EventEvacuationInformation e;
146146
if (e.should_commit()) {
147147
e.set_gcId(GCId::current());
148-
e.set_cSetRegions(info->collectionset_regions());
149-
e.set_cSetUsedBefore(info->collectionset_used_before());
150-
e.set_cSetUsedAfter(info->collectionset_used_after());
148+
e.set_cSetRegions(info->collection_set_regions());
149+
e.set_cSetUsedBefore(info->collection_set_used_before());
150+
e.set_cSetUsedAfter(info->collection_set_used_after());
151151
e.set_allocationRegions(info->allocation_regions());
152152
e.set_allocationRegionsUsedBefore(info->alloc_regions_used_before());
153153
e.set_allocationRegionsUsedAfter(info->alloc_regions_used_before() + info->bytes_used());

‎src/hotspot/share/gc/g1/g1YoungCollector.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ void G1YoungCollector::calculate_collection_set(G1EvacInfo* evacuation_info, dou
271271
allocator()->release_mutator_alloc_regions();
272272

273273
collection_set()->finalize_initial_collection_set(target_pause_time_ms, survivor_regions());
274-
evacuation_info->set_collectionset_regions(collection_set()->region_length() +
274+
evacuation_info->set_collection_set_regions(collection_set()->region_length() +
275275
collection_set()->optional_region_length());
276276

277277
concurrent_mark()->verify_no_collection_set_oops();
@@ -1020,7 +1020,7 @@ void G1YoungCollector::post_evacuate_collection_set(G1EvacInfo* evacuation_info,
10201020

10211021
_g1h->record_obj_copy_mem_stats();
10221022

1023-
evacuation_info->set_collectionset_used_before(collection_set()->bytes_used_before());
1023+
evacuation_info->set_collection_set_used_before(collection_set()->bytes_used_before());
10241024
evacuation_info->set_bytes_used(_g1h->bytes_used_during_gc());
10251025

10261026
_g1h->start_new_collection_set();

‎src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ class FreeCSetStats {
465465

466466
void report(G1CollectedHeap* g1h, G1EvacInfo* evacuation_info) {
467467
evacuation_info->set_regions_freed(_regions_freed);
468-
evacuation_info->increment_collectionset_used_after(_after_used_bytes);
468+
evacuation_info->increment_collection_set_used_after(_after_used_bytes);
469469

470470
g1h->decrement_summary_bytes(_before_used_bytes);
471471
g1h->alloc_buffer_stats(G1HeapRegionAttr::Old)->add_failure_used_and_waste(_failure_used_words, _failure_waste_words);

0 commit comments

Comments
 (0)
Please sign in to comment.