Skip to content

Commit 85ec1f8

Browse files
ashu-mehrashipilev
authored andcommittedSep 8, 2022
8293492: ShenandoahControlThread missing from hs-err log and thread dump
Reviewed-by: zgu, shade
1 parent 6bd2794 commit 85ec1f8

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed
 

‎src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp

+1-11
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ ShenandoahControlThread::ShenandoahControlThread() :
5454
_requested_gc_cause(GCCause::_no_cause_specified),
5555
_degen_point(ShenandoahGC::_degenerated_outside_cycle),
5656
_allocs_seen(0) {
57-
57+
set_name("Shenandoah Control Thread");
5858
reset_gc_id();
5959
create_and_start();
6060
_periodic_task.enroll();
@@ -626,16 +626,6 @@ size_t ShenandoahControlThread::get_gc_id() {
626626
return Atomic::load(&_gc_id);
627627
}
628628

629-
void ShenandoahControlThread::print() const {
630-
print_on(tty);
631-
}
632-
633-
void ShenandoahControlThread::print_on(outputStream* st) const {
634-
st->print("Shenandoah Concurrent Thread");
635-
Thread::print_on(st);
636-
st->cr();
637-
}
638-
639629
void ShenandoahControlThread::start() {
640630
create_and_start();
641631
}

‎src/hotspot/share/gc/shenandoah/shenandoahControlThread.hpp

-6
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,6 @@ class ShenandoahControlThread: public ConcurrentGCThread {
142142
void start();
143143
void prepare_for_graceful_shutdown();
144144
bool in_graceful_shutdown();
145-
146-
const char* name() const { return "ShenandoahControlThread";}
147-
148-
// Printing
149-
void print_on(outputStream* st) const;
150-
void print() const;
151145
};
152146

153147
#endif // SHARE_GC_SHENANDOAH_SHENANDOAHCONTROLTHREAD_HPP

‎src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1180,6 +1180,7 @@ void ShenandoahHeap::prepare_for_verify() {
11801180
}
11811181

11821182
void ShenandoahHeap::gc_threads_do(ThreadClosure* tcl) const {
1183+
tcl->do_thread(_control_thread);
11831184
workers()->threads_do(tcl);
11841185
if (_safepoint_workers != NULL) {
11851186
_safepoint_workers->threads_do(tcl);

0 commit comments

Comments
 (0)
Please sign in to comment.