8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak

zhengyu123 · zhengyu123 · commit dfaa89162a35 · 2025-01-06T13:44:35.000Z
Reviewed-by: wkemper, shade
diff --git a/src/hotspot/share/gc/shenandoah/shenandoahWorkGroup.cpp b/src/hotspot/share/gc/shenandoah/shenandoahWorkGroup.cpp
@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2017, 2021, Red Hat, Inc. All rights reserved.
+ * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -73,7 +74,6 @@ ShenandoahPushWorkerScope::~ShenandoahPushWorkerScope() {
 }
 
 void ShenandoahWorkerThreads::on_create_worker(WorkerThread* worker) {
-  ShenandoahThreadLocalData::create(worker);
   if (_initialize_gclab) {
     ShenandoahThreadLocalData::initialize_gclab(worker);
   }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`/*`
`2`	`2`	`* Copyright (c) 2017, 2021, Red Hat, Inc. All rights reserved.`
	`3`	`+ * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.`
`3`	`4`	`* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.`
`4`	`5`	`*`
`5`	`6`	`* This code is free software; you can redistribute it and/or modify it`
`@@ -73,7 +74,6 @@ ShenandoahPushWorkerScope::~ShenandoahPushWorkerScope() {`
`73`	`74`	`}`
`74`	`75`
`75`	`76`	`void ShenandoahWorkerThreads::on_create_worker(WorkerThread* worker) {`
`76`		`- ShenandoahThreadLocalData::create(worker);`
`77`	`77`	`if (_initialize_gclab) {`
`78`	`78`	`ShenandoahThreadLocalData::initialize_gclab(worker);`
`79`	`79`	`}`