8295353: Mark Register v24 as Volatile in Foreign Function & Memory C ABI Definition

[swesonga]

The C ABI defined by the Foreign Function & Memory API does not include v24 in the list of volatile floating point vector registers. As per the spec, v16-v31 do not need to be preserved. See https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst#612simd-and-floating-point-registers

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8295353: Mark Register v24 as Volatile in Foreign Function & Memory C ABI Definition

Reviewers

• Jorn Vernee (@JornVernee - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-foreign pull/743/head:pull/743
$ git checkout pull/743

Update a local copy of the PR:
$ git checkout pull/743
$ git pull https://git.openjdk.org/panama-foreign pull/743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 743

View PR using the GUI difftool:
$ git pr show -t 743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-foreign/pull/743.diff

[bridgekeeper]

Hi @swesonga, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user swesonga" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[swesonga]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[JornVernee]

Is this still supposed to be a draft?

[mlbridge]

Webrevs

• 00: Full (9c4c0808)

[openjdk]

@swesonga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295353: Mark Register v24 as Volatile in Foreign Function & Memory C ABI Definition

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 203 new commits pushed to the foreign-memaccess+abi branch:

• 9e9d411: Automatic merge of master into foreign-memaccess+abi
• 9535c25: Automatic merge of jdk:master into master
• cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
• 4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
• d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
• fd668dc: 8295537: Enhance TRACE_METHOD_LINKAGE to show the target MethodHandle
• 182c215: 8295994: Remove left over InetAddressContainer class
• 78763fc: 8295000: java/util/Formatter/Basic test cleanup
• 907d583: 8295323: Unnecessary HashTable usage in StyleSheet
• 2157145: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
• ... and 193 more: https://git.openjdk.org/panama-foreign/compare/15a1ec23efc74e5e483168cd8d75cabb0148e544...foreign-memaccess+abi

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[swesonga]

/integrate

[openjdk]

@swesonga
Your change (at version 9c4c080) is now ready to be sponsored by a Committer.

[JornVernee]

/integrate

[JornVernee]

Thanks for fixing!

[openjdk]

@JornVernee Only the author (@swesonga) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[JornVernee]

/sponsor

[openjdk]

Going to push as commit bee7072.
Since your change was applied there have been 203 commits pushed to the foreign-memaccess+abi branch:

• 9e9d411: Automatic merge of master into foreign-memaccess+abi
• 9535c25: Automatic merge of jdk:master into master
• cf5546b: 8291336: Add ideal rule to convert floating point multiply by 2 into addition
• 4b89fce: 8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck
• d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
• fd668dc: 8295537: Enhance TRACE_METHOD_LINKAGE to show the target MethodHandle
• 182c215: 8295994: Remove left over InetAddressContainer class
• 78763fc: 8295000: java/util/Formatter/Basic test cleanup
• 907d583: 8295323: Unnecessary HashTable usage in StyleSheet
• 2157145: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
• ... and 193 more: https://git.openjdk.org/panama-foreign/compare/15a1ec23efc74e5e483168cd8d75cabb0148e544...foreign-memaccess+abi

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee @swesonga Pushed as commit bee7072.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.