Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299373: Extend vector conversion APIs for Halffloat type. #208

Closed

Conversation

swati-sha
Copy link
Contributor

@swati-sha swati-sha commented Dec 28, 2022

Hi All,

The patch contains the below changes:

  • Extended existing conversion APIs (convertShape, castShape, convert) for half float vectors.
  • Define new conversion operators for casting to/from halffloat type.
  • Extended existing JTREG conversion tests for half float types.

Please review and provide your feedback.

Thanks,
Swati


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8299373: Extend vector conversion APIs for Halffloat type.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.org/panama-vector pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/208.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2022

👋 Welcome back swati-sha! A progress list of the required criteria for merging this PR into vectorIntrinsics+fp16 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 28, 2022
@swati-sha
Copy link
Contributor Author

swati-sha commented Dec 28, 2022

/contributor add @jatin-bhateja

@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@swati-sha Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@mlbridge
Copy link

mlbridge bot commented Dec 28, 2022

Webrevs

for (int i = 0; i < length; i++) {
Number v = (Number) Array.get(src, srcPos + i);
Array.set(dest, destPos + i, c.apply(v));
if (srcSpecies.elementType() == Halffloat.class) {
v = (Number) Halffloat.valueOf(v.shortValue()).floatValue();
Copy link
Member

@jatin-bhateja jatin-bhateja Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason for not directly calling Float.float16ToFloat(short) here ?

Copy link
Contributor Author

@swati-sha swati-sha Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jatin-bhateja
Copy link
Member

LGTM

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@swati-sha This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299373: Extend vector conversion APIs for Halffloat type.

Reviewed-by: jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the vectorIntrinsics+fp16 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jatin-bhateja) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 9, 2023
@swati-sha
Copy link
Contributor Author

/integrate

@jatin-bhateja
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@swati-sha
Your change (at version 6c0579a) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit 9113b20.

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@jatin-bhateja @swati-sha Pushed as commit 9113b20.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants