-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299373: Extend vector conversion APIs for Halffloat type. #208
Conversation
👋 Welcome back swati-sha! A progress list of the required criteria for merging this PR into |
/contributor add @jatin-bhateja |
@swati-sha Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
Webrevs
|
for (int i = 0; i < length; i++) { | ||
Number v = (Number) Array.get(src, srcPos + i); | ||
Array.set(dest, destPos + i, c.apply(v)); | ||
if (srcSpecies.elementType() == Halffloat.class) { | ||
v = (Number) Halffloat.valueOf(v.shortValue()).floatValue(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for not directly calling Float.float16ToFloat(short) here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM |
@swati-sha This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jatin-bhateja) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@swati-sha |
Going to push as commit 9113b20. |
@jatin-bhateja @swati-sha Pushed as commit 9113b20. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi All,
The patch contains the below changes:
Please review and provide your feedback.
Thanks,
Swati
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/panama-vector pull/208/head:pull/208
$ git checkout pull/208
Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.org/panama-vector pull/208/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 208
View PR using the GUI difftool:
$ git pr show -t 208
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/panama-vector/pull/208.diff