Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic #10

Merged
merged 1 commit into from Mar 11, 2023

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Mar 9, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8295926. Applies cleanly.
Case test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java failed before this patch.

Testing:

  • test/hotspot/jtreg/compiler/floatingpoint/TestLibmIntrinsics.java passed on qemu and unmatched.
  • Tier1 passed without new failure on unmacthed (release).

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ This PR only contains changes already present in the target

Issue

  • JDK-8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/10.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1fdbb1ba337b07dbcfb3c28c4fdeba74fee113dc 8295926: RISC-V: C1: Fix LIRGenerator::do_LibmIntrinsic Mar 9, 2023
@openjdk
Copy link

openjdk bot commented Mar 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 9, 2023

@DingliZhang This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 9, 2023

Webrevs

Copy link
Collaborator

@zhengxiaolinX zhengxiaolinX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you.

@RealFYang RealFYang merged commit 75180c4 into openjdk:riscv-port Mar 11, 2023
1 check passed
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants