-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290496: riscv: Fix build warnings-as-errors with GCC 11 #2
8290496: riscv: Fix build warnings-as-errors with GCC 11 #2
Conversation
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Your backport is clean so it doesn't need a review. This Qs is not for @DingliZhang , but general one |
Here is what I am think about the backporting work flow for this repo. Here in our case for riscv-port-jdk17u repo, I am not expecting uses of labels/comments on the JBS issue for request approvals, which is required by the upstream backporting flow. I think it's better to do that (like marking the JBS issues for requesting maintainer approvals) when we do the final upstreaming to jdk17u-dev repo. [1] openjdk/lilliput#67 |
Hello @RealFYang, thanks to explanation, however one moment isn't clear yet In case of "clean" backports, can we request integration right away ? |
Just ping me on the PR when you have a clean backport :-) |
Backport-of: a9b0f9ccbf98c6b90626fcd7087fa8eeb0c168eb
Please review this backport to riscv-port-jdk17u.
Backport of JDK-8290496. Applies cleanly.
Build without --disable-warnings-as-errors after this fix passed on unmatched board with GCC11.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/2/head:pull/2
$ git checkout pull/2
Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/2/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2
View PR using the GUI difftool:
$ git pr show -t 2
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/2.diff