Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290496: riscv: Fix build warnings-as-errors with GCC 11 #2

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Feb 28, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8290496. Applies cleanly.

Build without --disable-warnings-as-errors after this fix passed on unmatched board with GCC11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290496: riscv: Fix build warnings-as-errors with GCC 11

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/2.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2023

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5425573bb4de1a2434201bc7ec3700b527ce346b 8290496: riscv: Fix build warnings-as-errors with GCC 11 Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290496: riscv: Fix build warnings-as-errors with GCC 11

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2023

Webrevs

@VladimirKempik
Copy link
Contributor

Your backport is clean so it doesn't need a review.
However, the process is not clear yet: who would approve backports in this project ? how to request approval ?
Also, Can anyone, who is already reviewer in jdk-updates-project become reviewer in riscv-port-jdk17u ?

This Qs is not for @DingliZhang , but general one

@RealFYang
Copy link
Member

RealFYang commented Feb 28, 2023

@VladimirKempik

Here is what I am think about the backporting work flow for this repo.
Since we are not upstreamed yet, I think we could follow a simplified workflow here. In fact, if you look at other projects like Lilliput or ZGC, they also follow a rather simplified flow for PR integration. In these cases, Committers could also do code reviews [1] and you don't even need a JBS issue for creating a PR [2].

Here in our case for riscv-port-jdk17u repo, I am not expecting uses of labels/comments on the JBS issue for request approvals, which is required by the upstream backporting flow. I think it's better to do that (like marking the JBS issues for requesting maintainer approvals) when we do the final upstreaming to jdk17u-dev repo.
So any people who are familar with the riscv port could review a PR for riscv-port-jdk17u repo. When a backporting PR for this repo is clean or is fully reviewed, I could help do the final integration. I am open to other suggestions.

[1] openjdk/lilliput#67
[2] openjdk/zgc#1

@VladimirKempik
Copy link
Contributor

Hello @RealFYang, thanks to explanation, however one moment isn't clear yet

In case of "clean" backports, can we request integration right away ?

@RealFYang
Copy link
Member

Hello @RealFYang, thanks to explanation, however one moment isn't clear yet

In case of "clean" backports, can we request integration right away ?

Just ping me on the PR when you have a clean backport :-)
I am not sure if the bot could be configured to help with that.

@RealFYang RealFYang merged commit 501e1b1 into openjdk:riscv-port Feb 28, 2023
openjdk bot pushed a commit that referenced this pull request Mar 14, 2025
Backport-of: a9b0f9ccbf98c6b90626fcd7087fa8eeb0c168eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants