Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() #24

Merged
merged 1 commit into from Mar 27, 2023

Conversation

zhengxiaolinX
Copy link
Collaborator

@zhengxiaolinX zhengxiaolinX commented Mar 23, 2023

Tested along with remaining patches, hotspot tier1~4 with fastdebug build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/24/head:pull/24
$ git checkout pull/24

Update a local copy of the PR:
$ git checkout pull/24
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/24/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24

View PR using the GUI difftool:
$ git pr show -t 24

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/24.diff

…ssembler::relocate()

Reviewed-by: fjiang, yadongwang, fyang
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2023

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 23, 2023

⚠️ @zhengxiaolinX the given backport hash 1ea8aee89e414b2eedfb4a1f91202edfb882f55f is an ancestor of your proposed change. Please update the title with the hash for the change you are backporting.

@zhengxiaolinX zhengxiaolinX changed the title Backport 1ea8aee89e414b2eedfb4a1f91202edfb882f55f Backport 664e5b1d2e91107a3bae5b4b95d5724cf241a55f Mar 23, 2023
@openjdk openjdk bot changed the title Backport 664e5b1d2e91107a3bae5b4b95d5724cf241a55f 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate() Mar 23, 2023
@openjdk
Copy link

openjdk bot commented Mar 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@zhengxiaolinX This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 23, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@RealFYang RealFYang merged commit bec4243 into openjdk:riscv-port Mar 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants