Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305006: Use correct register in riscv_enc_fast_unlock() #27

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Mar 24, 2023

Please help review this backport to riscv-port-jdk17u.
Backport of JDK-8296136. because JDK-8296136 is already present in 17.0.7(jdk17u-dev repo) and riscv-port-jdk17u too. so I created a new issue for this PR.

Testing:

  • Tier1 passed without new failure on qemu (release).

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305006: Use correct register in riscv_enc_fast_unlock()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/27/head:pull/27
$ git checkout pull/27

Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/27/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27

View PR using the GUI difftool:
$ git pr show -t 27

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/27.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7619602c365acee73a490f05be2bd0d3dd09d7a4 8296136: Use correct register in aarch64_enc_fast_unlock() Mar 24, 2023
@openjdk
Copy link

openjdk bot commented Mar 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 24, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2023

Webrevs

@VladimirKempik
Copy link
Contributor

VladimirKempik commented Mar 24, 2023

Hello
it's wrong to use JDK-8296136 for this fix
JDK-8296136 is already present in 17.0.7(jdk17u-dev repo) and riscv-port-jdk17u too.
You would need to create new jbs issue, for example - "Use correct register in riscv_enc_fast_lock()" and then use it in your pull request

@RealFYang
Copy link
Member

RealFYang commented Mar 24, 2023

Hello it's wrong to use JDK-8296136 for this fix JDK-8296136 is already present in 17.0.7(jdk17u-dev repo) and riscv-port-jdk17u too. You would need to create new jbs issue, for example - "Use correct register in riscv_enc_fast_lock()" and then use it in your pull request

Agreed. This reminds me that we might need repo-specific entries like 'repo-riscv-port-jdk17u' for the Affected and Fix Version fields on JBS for this backport repo. Let me try to contact ops.

@RealFYang
Copy link
Member

Now we have three new JBS versions for the backport repos: "repo-riscv-port-17", "repo-riscv-port"11", "repo-riscv-port-8".

@zifeihan zifeihan changed the title 8296136: Use correct register in aarch64_enc_fast_unlock() 8305006: RISC-V: Use correct register in riscv_enc_fast_unlock() Mar 28, 2023
@zifeihan zifeihan changed the title 8305006: RISC-V: Use correct register in riscv_enc_fast_unlock() 8305006: Use correct register in riscv_enc_fast_unlock() Mar 28, 2023
@zifeihan
Copy link
Member Author

zifeihan commented Mar 28, 2023

Hello it's wrong to use JDK-8296136 for this fix JDK-8296136 is already present in 17.0.7(jdk17u-dev repo) and riscv-port-jdk17u too. You would need to create new jbs issue, for example - "Use correct register in riscv_enc_fast_lock()" and then use it in your pull request

@VladimirKempik Thanks for the review, I have created a new issue and used it in my pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305006: Use correct register in riscv_enc_fast_unlock()

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the riscv-port branch:

  • b0425c7: 8300109: RISC-V: Improve code generation for MinI/MaxI nodes
  • b9d856f: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension
  • bec4243: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
  • 19d2e80: Merge branch 'master' into riscv-port
  • 637155e: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
  • 6d61fc1: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError
  • 04e337c: 8303575: adjust Xen handling on Linux aarch64
  • 8a2425d: 8300042: Improve CPU related JFR events descriptions
  • 3b64bde: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • cc170c7: 8292301: [REDO v2] C2 crash when allocating array of size too large
  • ... and 2 more: https://git.openjdk.org/riscv-port-jdk17u/compare/c3083f9a68f493ea0b214d0182c08f406ebc0fc3...riscv-port

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@VladimirKempik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2023
@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 28, 2023
@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@zifeihan
Your change (at version 20dcce7) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 28, 2023

Going to push as commit aad6323.
Since your change was applied there have been 12 commits pushed to the riscv-port branch:

  • b0425c7: 8300109: RISC-V: Improve code generation for MinI/MaxI nodes
  • b9d856f: 8297715: RISC-V: C2: Use single-bit instructions from the Zbs extension
  • bec4243: 8294187: RISC-V: Unify all relocations for the backend into AbstractAssembler::relocate()
  • 19d2e80: Merge branch 'master' into riscv-port
  • 637155e: 8303102: jcmd: ManagementAgent.status truncates the text longer than O_BUFLEN
  • 6d61fc1: 8227257: javax/swing/JFileChooser/4847375/bug4847375.java fails with AssertionError
  • 04e337c: 8303575: adjust Xen handling on Linux aarch64
  • 8a2425d: 8300042: Improve CPU related JFR events descriptions
  • 3b64bde: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • cc170c7: 8292301: [REDO v2] C2 crash when allocating array of size too large
  • ... and 2 more: https://git.openjdk.org/riscv-port-jdk17u/compare/c3083f9a68f493ea0b214d0182c08f406ebc0fc3...riscv-port

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2023
@openjdk openjdk bot closed this Mar 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 28, 2023
@openjdk
Copy link

openjdk bot commented Mar 28, 2023

@RealFYang @zifeihan Pushed as commit aad6323.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the backport-JDK-8296136 branch February 28, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants