New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305006: Use correct register in riscv_enc_fast_unlock() #27
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Hello |
Agreed. This reminds me that we might need repo-specific entries like 'repo-riscv-port-jdk17u' for the Affected and Fix Version fields on JBS for this backport repo. Let me try to contact ops. |
Now we have three new JBS versions for the backport repos: "repo-riscv-port-17", "repo-riscv-port"11", "repo-riscv-port-8". |
@VladimirKempik Thanks for the review, I have created a new issue and used it in my pull request. |
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@VladimirKempik) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit aad6323.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit aad6323. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please help review this backport to riscv-port-jdk17u.
Backport of JDK-8296136. because JDK-8296136 is already present in 17.0.7(jdk17u-dev repo) and riscv-port-jdk17u too. so I created a new issue for this PR.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/27/head:pull/27
$ git checkout pull/27
Update a local copy of the PR:
$ git checkout pull/27
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/27/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27
View PR using the GUI difftool:
$ git pr show -t 27
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/27.diff