Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296771: RISC-V: C2: assert(false) failed: bad AD file #8

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Mar 7, 2023

Please review this backport to riscv-port-jdk17u.
Backport of JDK-8296771. Applies cleanly.
By the way, we can directly use compiler/types/TestSubTypeCheckMacroTrichotomy.java to reproduce the bad ad file error.

Testing:

  • compiler/types/TestSubTypeCheckMacroTrichotomy.java passed on qemu/unmatched (fastdebug).
  • Tier1 passed without new failure on unmacthed (release).

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296771: RISC-V: C2: assert(false) failed: bad AD file

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.org/riscv-port-jdk17u pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/8.diff

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
headius Charles Oliver Nutter
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7244eac9dfe4e7e9c3eea613149f0fb1390f00aa 8296771: RISC-V: C2: assert(false) failed: bad AD file Mar 7, 2023
@openjdk
Copy link

openjdk bot commented Mar 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296771: RISC-V: C2: assert(false) failed: bad AD file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2023

Webrevs

@RealFYang RealFYang merged commit 0a74c41 into openjdk:riscv-port Mar 9, 2023
@zifeihan zifeihan deleted the backport-JDK-8296771 branch March 10, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants