Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329789: GenShen: Over assertive assert when scanning remembered set #34

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -772,7 +772,11 @@ void ShenandoahScanRemembered<RememberedSet>::process_clusters(size_t first_clus
} else {
// ==== BEGIN CLEAN card range processing ====

assert(ctbm[cur_index] == CardTable::clean_card_val(), "Error");
// If we are using the write table (during update refs, e.g.), a mutator may dirty
// a card at any time. This is fine for the algorithm below because it is only
// counting contiguous runs of clean cards (and only for non-product builds).
assert(use_write_table || ctbm[cur_index] == CardTable::clean_card_val(), "Error");

// walk back over contiguous clean cards
size_t i = 0;
while (--cur_index >= (ssize_t)start_card_index && ctbm[cur_index] == CardTable::clean_card_val()) {