Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332254: GenShen: Remove obsolete comments and revert unnecessary formatting changes #48

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented May 17, 2024

Clean backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332254: GenShen: Remove obsolete comments and revert unnecessary formatting changes (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah-jdk21u.git pull/48/head:pull/48
$ git checkout pull/48

Update a local copy of the PR:
$ git checkout pull/48
$ git pull https://git.openjdk.org/shenandoah-jdk21u.git pull/48/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 48

View PR using the GUI difftool:
$ git pr show -t 48

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah-jdk21u/pull/48.diff

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 17, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332254: GenShen: Remove obsolete comments and revert unnecessary formatting changes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • dbbc2d2: 8332094: GenShen: Reuse existing code to verify usage before rebuilding free set
  • 0efff56: 8331609: GenShen: Refactor generational mode allocations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport dfa788667714b4ec7e0e235e9c0c58cc5e3ceab4 8332254: GenShen: Remove obsolete comments and revert unnecessary formatting changes May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@mlbridge
Copy link

mlbridge bot commented May 17, 2024

Webrevs

@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit 0719cab.
Since your change was applied there have been 2 commits pushed to the master branch:

  • dbbc2d2: 8332094: GenShen: Reuse existing code to verify usage before rebuilding free set
  • 0efff56: 8331609: GenShen: Refactor generational mode allocations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@earthling-amzn Pushed as commit 0719cab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant