Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary checks identified by reviewer #146

Closed
wants to merge 1 commit into from

Conversation

kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Jun 24, 2022

A previous pull request was integrated before all of the reviewer
comments had been addressed. This commit addresses the lingering
request.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah pull/146/head:pull/146
$ git checkout pull/146

Update a local copy of the PR:
$ git checkout pull/146
$ git pull https://git.openjdk.org/shenandoah pull/146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 146

View PR using the GUI difftool:
$ git pr show -t 146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/146.diff

Sorry, something went wrong.

A previous pull request was integrated before all of the reviewer
comments had been addressed.  This commit addresses the lingering
request.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2022

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2022

Webrevs

@ysramakrishna
Copy link
Member

ysramakrishna commented Jun 24, 2022

For context, could you link to the previous reviewer feedback that this addresses? Thanks!

@kdnilsen
Copy link
Contributor Author

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Remove unnecessary checks identified by reviewer

Reviewed-by: wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 24, 2022
Copy link
Member

@ysramakrishna ysramakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context. This looks good!

@kdnilsen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2022

Going to push as commit 0fefe70.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2022
@openjdk openjdk bot closed this Jun 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2022
@openjdk
Copy link

openjdk bot commented Jun 24, 2022

@kdnilsen Pushed as commit 0fefe70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants