-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary checks identified by reviewer #146
Conversation
A previous pull request was integrated before all of the reviewer comments had been addressed. This commit addresses the lingering request.
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
For context, could you link to the previous reviewer feedback that this addresses? Thanks! |
for context of original feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update
@kdnilsen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context. This looks good!
/integrate |
Going to push as commit 0fefe70. |
A previous pull request was integrated before all of the reviewer
comments had been addressed. This commit addresses the lingering
request.
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah pull/146/head:pull/146
$ git checkout pull/146
Update a local copy of the PR:
$ git checkout pull/146
$ git pull https://git.openjdk.org/shenandoah pull/146/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 146
View PR using the GUI difftool:
$ git pr show -t 146
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/146.diff