Remove redundant initialization code

[kdnilsen]

This code and the assertions that acompany it are subject to races with certain GC worker threads which are also capturing top_at_mark_start() and may capture it at a different position than this thread does.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewers

• Aleksey Shipilev (@shipilev - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/shenandoah.git pull/267/head:pull/267
$ git checkout pull/267

Update a local copy of the PR:
$ git checkout pull/267
$ git pull https://git.openjdk.org/shenandoah.git pull/267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 267

View PR using the GUI difftool:
$ git pr show -t 267

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/shenandoah/pull/267.diff

[bridgekeeper]

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[shipilev]

I am actually surprised the allocation code does anything with TAMS. TAMS is supposed to be only updated by GC threads, well, at mark start :) I see this reverts the relevant block almost to upstream state, so thumbs up.

[openjdk]

@kdnilsen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Remove redundant initialization code

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• d254fb2: Usage tracking cleanup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kdnilsen]

/integrate

[openjdk]

Going to push as commit b442302.
Since your change was applied there has been 1 commit pushed to the master branch:

• d254fb2: Usage tracking cleanup

Your commit was automatically rebased without conflicts.

[openjdk]

@kdnilsen Pushed as commit b442302.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (40d7047c)