2468: PR bot mistakenly stop warning about empty pr body

zhaosongzs · zhaosongzs · commit 251b71aa1819 · 2025-03-26T17:46:05.000Z
Reviewed-by: erikj
diff --git a/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java b/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
@@ -240,7 +240,8 @@ private List<String> allowedTargetBranches() {
     private List<String> botSpecificChecks(boolean iscleanBackport) {
         var ret = new ArrayList<String>();
 
-        if (bodyWithoutStatus().isBlank() && !iscleanBackport) {
+        var bodyWithoutStatus = bodyWithoutStatus();
+        if ((bodyWithoutStatus.isBlank() || bodyWithoutStatus.equals(EMPTY_PR_BODY_MARKER)) && !iscleanBackport) {
             ret.add(MSG_EMPTY_BODY);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,8 @@ private List<String> allowedTargetBranches() {`
`240`	`240`	`private List<String> botSpecificChecks(boolean iscleanBackport) {`
`241`	`241`	`var ret = new ArrayList<String>();`
`242`	`242`
`243`		`- if (bodyWithoutStatus().isBlank() && !iscleanBackport) {`
	`243`	`+ var bodyWithoutStatus = bodyWithoutStatus();`
	`244`	`+ if ((bodyWithoutStatus.isBlank() \|\| bodyWithoutStatus.equals(EMPTY_PR_BODY_MARKER)) && !iscleanBackport) {`
`244`	`245`	`ret.add(MSG_EMPTY_BODY);`
`245`	`246`	`}`
`246`	`247`