Skip to content

1562: The method 'CheckRun#findComment' don't need the comment list as parameter #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+25 −26
Closed

1562: The method 'CheckRun#findComment' don't need the comment list as parameter #1375

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a015ec5
remove parameter 'comments' in CheckRun#findComment
zhaosongzs Sep 15, 2022
43060dd
refactor code related with activeReviews in CheckRun
zhaosongzs Sep 16, 2022
b5a2f2a
fix a linebreak
zhaosongzs Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
View file
Original file line number Diff line number Diff line change
@@ -1070,8 +1070,7 @@ private void checkStatus() {
var integrationBlockers = botSpecificIntegrationBlockers();

// Calculate and update the status message if needed
var statusMessage = getStatusMessage(visitor, additionalErrors,
additionalProgresses, integrationBlockers, isCleanBackport);
var statusMessage = getStatusMessage(visitor, additionalErrors, additionalProgresses, integrationBlockers, isCleanBackport);
var updatedBody = updateStatusMessage(statusMessage);
var title = pr.title();