1722: Add duration logging for RestRequestCache lock

[erikj79]

This patch adds additional logging of durations for things that take time. In this case it's measuring how long it takes to get the lock before calling a remote REST API.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace

Issue

• SKARA-1722: Add duration logging for RestRequestCache lock

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/skara pull/1444/head:pull/1444
$ git checkout pull/1444

Update a local copy of the PR:
$ git checkout pull/1444
$ git pull https://git.openjdk.org/skara pull/1444/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1444

View PR using the GUI difftool:
$ git pr show -t 1444

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/skara/pull/1444.diff

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (efc0b050)

[magicus]

Should this not be accompanied with any logging?

[magicus]

Ah, I see, you measure the time across two locks. Nevermind.

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

1722: Add duration logging for RestRequestCache lock

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 28fe36f: 1710: CommitCommandWorkItem always fetches Commit
• 531bf96: 1709: Only fetch comments once in PullRequestWorkItem in pr bot

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[erikj79]

/integrate

[openjdk]

Going to push as commit 3620b0e.
Since your change was applied there have been 3 commits pushed to the master branch:

• affcd47: 1598: GitRepository.isHealthy takes a long time in ArchiveWorkItem
• 28fe36f: 1710: CommitCommandWorkItem always fetches Commit
• 531bf96: 1709: Only fetch comments once in PullRequestWorkItem in pr bot

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 Pushed as commit 3620b0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.