8293126: [lworld] follow-up for JDK-8293120

Author: Vicente Romero

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java

@@ -1468,8 +1468,14 @@ else if ((sym.owner.flags_field & INTERFACE) != 0)
                 implicit |= VALUE_CLASS | FINAL;
 
             // concrete value classes are implicitly final
-            if ((flags & (ABSTRACT | INTERFACE | VALUE_CLASS)) == VALUE_CLASS)
+            if ((flags & (ABSTRACT | INTERFACE | VALUE_CLASS)) == VALUE_CLASS) {
                 implicit |= FINAL;
+                if ((flags & NON_SEALED) != 0) {
+                    // cant declare a final value class non-sealed
+                    log.error(pos,
+                            Errors.ModNotAllowedHere(asFlagSet(NON_SEALED)));
+                }
+            }
 
             // TYPs can't be declared synchronized
             mask &= ~SYNCHRONIZED;

test/langtools/tools/javac/valhalla/value-objects/ValueObjectCompilationTests.java

@@ -25,7 +25,7 @@
  * ValueObjectCompilationTests
  *
  * @test
- * @bug 8287136 8292630 8279368 8287136 8287770 8279840 8279672 8292753 8287763 8279901 8287767
+ * @bug 8287136 8292630 8279368 8287136 8287770 8279840 8279672 8292753 8287763 8279901 8287767 8293183 8293120
  * @summary Negative compilation tests, and positive compilation (smoke) tests for Value Objects
  * @library /lib/combo /tools/lib
  * @modules
@@ -533,4 +533,46 @@ value interface VI {}
                 class BIC implements VI {} // Error
                 """);
     }
+
+    public void testInteractionWithSealedClasses() {
+        assertOK(
+                """
+                abstract sealed value class SC {}
+                value class VC extends SC {}
+                """
+        );assertOK(
+                """
+                abstract sealed value interface SI {}
+                value class VC implements SI {}
+                """
+        );
+        assertOK(
+                """
+                abstract sealed identity class SC {}
+                final identity class IC extends SC {}
+                non-sealed identity class IC2 extends SC {}
+                final identity class IC3 extends IC2 {}
+                """
+        );
+        assertOK(
+                """
+                abstract sealed identity interface SI {}
+                final identity class IC implements SI {}
+                non-sealed identity class IC2 implements SI {}
+                final identity class IC3 extends IC2 {}
+                """
+        );
+        assertFail("compiler.err.mod.not.allowed.here",
+                """
+                abstract sealed value class SC {}
+                non-sealed value class VC extends SC {}
+                """
+        );
+        assertFail("compiler.err.mod.not.allowed.here",
+                """
+                sealed value interface SI {}
+                non-sealed value class VC implements SI {}
+                """
+        );
+    }
 }