8324784: [lworld] remove constant propagation code and tests

Author: Vicente Romero

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

@@ -1300,11 +1300,8 @@ public void visitVarDef(JCVariableDecl tree) {
             deferredLintHandler.flush(tree.pos());
             chk.checkDeprecatedAnnotation(tree.pos(), v);
 
-            /* Don't want constant propagation/folding for instance fields of primitive classes,
-               as these can undergo updates via copy on write.
-            */
             if (tree.init != null) {
-                if ((v.flags_field & FINAL) == 0 || ((v.flags_field & STATIC) == 0 && v.owner.isValueClass()) ||
+                if ((v.flags_field & FINAL) == 0 ||
                     !memberEnter.needsLazyConstValue(tree.init)) {
                     // Not a compile-time constant
                     // Attribute initializer in a new environment

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java

@@ -1887,7 +1887,6 @@ JCExpression makeOwnerThisN(DiagnosticPosition pos, Symbol sym, boolean preciseM
         List<VarSymbol> ots = outerThisStack;
         if (ots.isEmpty()) {
             log.error(pos, Errors.NoEnclInstanceOfTypeInScope(c));
-            Assert.error();
             return makeNull();
         }
         VarSymbol ot = ots.head;
@@ -1899,7 +1898,6 @@ JCExpression makeOwnerThisN(DiagnosticPosition pos, Symbol sym, boolean preciseM
                 ots = ots.tail;
                 if (ots.isEmpty()) {
                     log.error(pos, Errors.NoEnclInstanceOfTypeInScope(c));
-                    Assert.error();
                     return tree;
                 }
                 ot = ots.head;
@@ -2738,7 +2736,6 @@ JCFieldAccess makeIndyQualifier(
     }
 
     public void visitMethodDef(JCMethodDecl tree) {
-        // TODO - enum so is always <init>
         if (tree.name == names.init && (currentClass.flags_field&ENUM) != 0) {
             // Add "String $enum$name, int $enum$ordinal" to the beginning of the
             // argument list for each constructor of an enum.

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/MemberEnter.java

@@ -319,12 +319,9 @@ public void visitVarDef(JCVariableDecl tree) {
         VarSymbol v = new VarSymbol(0, name, vartype, enclScope.owner);
         v.flags_field = chk.checkFlags(tree.pos(), tree.mods.flags, v, tree);
         tree.sym = v;
-        /* Don't want constant propagation/folding for instance fields of primitive classes,
-           as these can undergo updates via copy on write.
-        */
         if (tree.init != null) {
             v.flags_field |= HASINIT;
-            if ((v.flags_field & FINAL) != 0 && ((v.flags_field & STATIC) != 0 || !v.owner.isValueClass()) &&
+            if ((v.flags_field & FINAL) != 0 &&
                 needsLazyConstValue(tree.init)) {
                 Env<AttrContext> initEnv = getInitEnv(tree, env);
                 initEnv.info.enclVar = v;

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java

@@ -3675,7 +3675,6 @@ class ArrayConstructorReferenceLookupHelper extends ReferenceLookupHelper {
 
         ArrayConstructorReferenceLookupHelper(JCMemberReference referenceTree, Type site, List<Type> argtypes,
                 List<Type> typeargtypes, MethodResolutionPhase maxPhase) {
-            // TODO - array constructor will be <init>
             super(referenceTree, names.init, site, argtypes, typeargtypes, maxPhase);
         }
 

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java

@@ -669,7 +669,6 @@ public void visitApply(JCMethodInvocation tree) {
         List<Type> argtypes = useInstantiatedPtArgs ?
                 tree.meth.type.getParameterTypes() :
                 mt.getParameterTypes();
-        // TODO - is enum so <init>
         if (meth.name == names.init && meth.owner == syms.enumSym)
             argtypes = argtypes.tail.tail;
         if (tree.varargsElement != null)

src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java

@@ -1596,8 +1596,7 @@ protected JCExpression term3() {
                     case LT:
                         if (!isMode(TYPE) && isParameterizedTypePrefix()) {
                             //this is either an unbound method reference whose qualifier
-                            //is a generic type i.e. A<S>::m or a default value creation of
-                            //the form ValueType<S>.default
+                            //is a generic type i.e. A<S>::m
                             int pos1 = token.pos;
                             accept(LT);
                             ListBuffer<JCExpression> args = new ListBuffer<>();