Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328019: [lworld] clean up library changes left from primitive class support #1045

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Mar 12, 2024

Clean up method handle change for JEP 401 and revert some leftover changes.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8328019: [lworld] clean up library changes left from primitive class support (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1045/head:pull/1045
$ git checkout pull/1045

Update a local copy of the PR:
$ git checkout pull/1045
$ git pull https://git.openjdk.org/valhalla.git pull/1045/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1045

View PR using the GUI difftool:
$ git pr show -t 1045

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1045.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328019: [lworld] clean up library changes left from primitive class support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • f0a50de: 8327639: [lworld] test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java fails with --enable-preview
  • 7749f99: 8293541: [lworld] IR verification fails for TestLWorld::test109_sharp and test110_sharp

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlchung
Copy link
Member Author

mlchung commented Mar 12, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 93f5fc8.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • f0a50de: 8327639: [lworld] test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java fails with --enable-preview
  • 7749f99: 8293541: [lworld] IR verification fails for TestLWorld::test109_sharp and test110_sharp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@mlchung Pushed as commit 93f5fc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

@mlchung mlchung deleted the JDK-8328019 branch April 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant