Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334334: [lworld] more test coverage for value classes #1136

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Jun 15, 2024

adding a reflection test for value classes


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8334334: [lworld] more test coverage for value classes (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1136/head:pull/1136
$ git checkout pull/1136

Update a local copy of the PR:
$ git checkout pull/1136
$ git pull https://git.openjdk.org/valhalla.git pull/1136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1136

View PR using the GUI difftool:
$ git pr show -t 1136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1136.diff

Sorry, something went wrong.

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2024

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 15, 2024

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334334: [lworld] more test coverage for value classes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 6935ee4: 8334313: [lworld] only concrete value classes should be listed in the LoadableDescriptors attribute

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jun 15, 2024

Going to push as commit 66dd65a.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 6935ee4: 8334313: [lworld] only concrete value classes should be listed in the LoadableDescriptors attribute

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 15, 2024
@openjdk openjdk bot closed this Jun 15, 2024
@openjdk
Copy link

openjdk bot commented Jun 15, 2024

@vicente-romero-oracle Pushed as commit 66dd65a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the JDK-8334334 branch June 15, 2024 21:51
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant