Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288600: [test] Revert IdentityObject interface change in java.naming test RunBasic #715

Closed

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Jun 16, 2022

The removal of the IdentityObject interface needs to be reflected in the ldap test golden files.
The interface does not appear in serialized objects.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8288600: [test] Revert IdentityObject interface change in java.naming test RunBasic

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla pull/715/head:pull/715
$ git checkout pull/715

Update a local copy of the PR:
$ git checkout pull/715
$ git pull https://git.openjdk.org/valhalla pull/715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 715

View PR using the GUI difftool:
$ git pr show -t 715

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/715.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2022

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 16, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2022

Webrevs

@RogerRiggs RogerRiggs changed the title 8288600: [test] Revert IdentityObject interface change in java.namig test RunBasic 8288600: [test] Revert IdentityObject interface change in java.naming test RunBasic Jun 16, 2022
@openjdk
Copy link

openjdk bot commented Jun 16, 2022

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288600: [test] Revert IdentityObject interface change in java.naming test RunBasic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 16, 2022
@RogerRiggs
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2022

Going to push as commit dff3d14.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 3d15c2f: 8287241: Add IdentityException to report that a value object is not valid

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jun 17, 2022
@openjdk openjdk bot closed this Jun 17, 2022
@openjdk
Copy link

openjdk bot commented Jun 17, 2022

@RogerRiggs Pushed as commit dff3d14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8288600-ldap-no-identity branch February 24, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant