8292753: [lworld] javac is accepting erroneous synchronized statements

[vicente-romero-oracle]

javac should issue an error for this code:

value class C<T extends C> {
    void m(T t) {
        synchronized(t) {}
    }
}

as type variable T is bounded by a value class. Also code like this one should be rejected:

value class C<T extends C> {
    void foo(Object o) {
        synchronized ((C & I)o) {} // one of the superclasses of the intersection type is a value class
    }
}

TIA

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8292753: [lworld] javac is accepting erroneous synchronized statements

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla pull/724/head:pull/724
$ git checkout pull/724

Update a local copy of the PR:
$ git checkout pull/724
$ git pull https://git.openjdk.org/valhalla pull/724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 724

View PR using the GUI difftool:
$ git pr show -t 724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/724.diff

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (9fef9d8a)
• 00: Full (56b9c163)

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292753: [lworld] javac is accepting erroneous synchronized statements

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

• 4a3131a: 8292630: [lworld] javac is accepting annotation interface declarations with modifiers: identity and value

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 3d9b4a7.
Since your change was applied there have been 5 commits pushed to the lworld branch:

• 2b23a95: 8292953: [lworld] Remove ValueCapableClass
• 5190d9a: 8292817: [lworld] add binary compatibility tests
• 8c772cc: 8292882: [lw4] PERMITS_VALUE should be removed from all source files
• c921671: 8292812: jvm test RunWithfieldTests.java fails with VerifyError exception
• 4a3131a: 8292630: [lworld] javac is accepting annotation interface declarations with modifiers: identity and value

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 3d9b4a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.