Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301899: [lworld] Value class APIs should have annotation for PreviewFeature #823

Closed

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Feb 7, 2023

Add the PreviewFeature for value objects and annotate new APIs.

Update tests to EnablePreview (all tests in test/jdk/valhalla/...)

Tier1-3 tests pass.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8301899: [lworld] Value class APIs should have annotation for PreviewFeature

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla pull/823/head:pull/823
$ git checkout pull/823

Update a local copy of the PR:
$ git checkout pull/823
$ git pull https://git.openjdk.org/valhalla pull/823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 823

View PR using the GUI difftool:
$ git pr show -t 823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/823.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2023

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 7, 2023

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301899: [lworld] Value class APIs should have annotation for PreviewFeature

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 2b29a9f: 8301664: [lworld] Inconsistent CastPP type leads to infinite loop in PhaseIterGVN::optimize

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Feb 7, 2023

Webrevs

@RogerRiggs
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 7, 2023

Going to push as commit 01d8cce.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 2b29a9f: 8301664: [lworld] Inconsistent CastPP type leads to infinite loop in PhaseIterGVN::optimize

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 7, 2023
@openjdk openjdk bot closed this Feb 7, 2023
@openjdk openjdk bot removed ready rfr labels Feb 7, 2023
@openjdk
Copy link

openjdk bot commented Feb 7, 2023

@RogerRiggs Pushed as commit 01d8cce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8301899-preview-feature branch March 14, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants