Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lw5] regression test cleanup, relocation #901

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Aug 9, 2023

cleaning up nullability related test, plus renaming them


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/901/head:pull/901
$ git checkout pull/901

Update a local copy of the PR:
$ git checkout pull/901
$ git pull https://git.openjdk.org/valhalla.git pull/901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 901

View PR using the GUI difftool:
$ git pr show -t 901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/901.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2023

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lw5 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[lw5] regression test cleanup, relocation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lw5 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lw5 branch, type /integrate in a new comment.

@vicente-romero-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

Going to push as commit 05f62bb.

@openjdk openjdk bot added the integrated label Aug 9, 2023
@openjdk openjdk bot closed this Aug 9, 2023
@openjdk openjdk bot removed ready rfr labels Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@vicente-romero-oracle Pushed as commit 05f62bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vicente-romero-oracle vicente-romero-oracle deleted the test.refactoring branch August 9, 2023 16:42
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2023

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant