Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311675: [lworld+vector] Max Species support. #931

Closed
wants to merge 5 commits into from
+6,447 −791
Closed

8311675: [lworld+vector] Max Species support. #931

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
822b024
[lworld+vector] Max Species support.
jatin-bhateja Sep 28, 2023
d721d71
Merge branch 'lworld+vector' of http://github.com/openjdk/valhalla in…
jatin-bhateja Oct 11, 2023
993674e
Review comments resolutions.
jatin-bhateja Oct 15, 2023
945eb0f
Review comments resolutions.
jatin-bhateja Oct 16, 2023
ffa108c
Review comments resolutions
jatin-bhateja Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
View file
Original file line number Diff line number Diff line change
@@ -657,3 +657,7 @@ void VM_Version::initialize_cpu_information(void) {

_initialized = true;
}

int VM_Version::max_vector_size(BasicType bt) {
return MaxVectorSize / type2aelembytes(bt);
}
Copy link

@XiaohongGong XiaohongGong Oct 16, 2023 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiaohongGong, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user XiaohongGong" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sorry, something went wrong.

3 changes: 3 additions & 0 deletions src/hotspot/cpu/aarch64/vm_version_aarch64.hpp
View file
Original file line number Diff line number Diff line change
@@ -190,6 +190,9 @@ enum Ampere_CPU_Model {
static bool use_neon_for_vector(int vector_length_in_bytes) {
return vector_length_in_bytes <= 16;
}

// Max supported vector lane count for a particular lane type.
static int max_vector_size(BasicType bt);
};

#endif // CPU_AARCH64_VM_VERSION_AARCH64_HPP
4 changes: 4 additions & 0 deletions src/hotspot/cpu/arm/vm_version_arm.hpp
View file
Original file line number Diff line number Diff line change
@@ -107,6 +107,10 @@ class VM_Version: public Abstract_VM_Version {
friend class VM_Version_StubGenerator;

static void initialize_cpu_information(void);

// Max supported vector lane count for a particular lane type.
static int max_vector_size(BasicType bt);

};

#endif // CPU_ARM_VM_VERSION_ARM_HPP
4 changes: 4 additions & 0 deletions src/hotspot/cpu/arm/vm_version_arm_32.cpp
View file
Original file line number Diff line number Diff line change
@@ -361,3 +361,7 @@ void VM_Version::initialize_cpu_information(void) {
snprintf(_cpu_desc, CPU_DETAILED_DESC_BUF_SIZE, "%s", _features_string);
_initialized = true;
}

int VM_Version::max_vector_size(BasicType bt) {
return MaxVectorSize / type2aelembytes(bt);
}
4 changes: 4 additions & 0 deletions src/hotspot/cpu/ppc/vm_version_ppc.cpp
View file
Original file line number Diff line number Diff line change
@@ -702,3 +702,7 @@ void VM_Version::initialize_cpu_information(void) {
snprintf(_cpu_desc, CPU_DETAILED_DESC_BUF_SIZE, "PPC %s", features_string());
_initialized = true;
}

int VM_Version::max_vector_size(BasicType bt) {
return MaxVectorSize / type2aelembytes(bt);
}
4 changes: 4 additions & 0 deletions src/hotspot/cpu/ppc/vm_version_ppc.hpp
View file
Original file line number Diff line number Diff line change
@@ -127,6 +127,10 @@ class VM_Version: public Abstract_VM_Version {
static uint64_t _dscr_val;

static void initialize_cpu_information(void);

// Max supported vector lane count for a particular lane type.
static int max_vector_size(BasicType bt);

};

#endif // CPU_PPC_VM_VERSION_PPC_HPP
4 changes: 4 additions & 0 deletions src/hotspot/cpu/riscv/vm_version_riscv.cpp
View file
Original file line number Diff line number Diff line change
@@ -349,3 +349,7 @@ void VM_Version::initialize_cpu_information(void) {
snprintf(_cpu_desc, CPU_DETAILED_DESC_BUF_SIZE, "RISCV64 %s", features_string());
_initialized = true;
}

int VM_Version::max_vector_size(BasicType bt) {
return MaxVectorSize / type2aelembytes(bt);
}
3 changes: 3 additions & 0 deletions src/hotspot/cpu/riscv/vm_version_riscv.hpp
View file
Original file line number Diff line number Diff line change
@@ -201,6 +201,9 @@ class VM_Version : public Abstract_VM_Version {
constexpr static bool supports_stack_watermark_barrier() { return true; }

static bool supports_on_spin_wait() { return UseZihintpause; }

// Max supported vector lane count for a particular lane type.
static int max_vector_size(BasicType bt);
};

#endif // CPU_RISCV_VM_VERSION_RISCV_HPP
4 changes: 4 additions & 0 deletions src/hotspot/cpu/s390/vm_version_s390.cpp
View file
Original file line number Diff line number Diff line change
@@ -1514,3 +1514,7 @@ void VM_Version::initialize_cpu_information(void) {
snprintf(_cpu_desc, CPU_DETAILED_DESC_BUF_SIZE, "s390 %s", features_string());
_initialized = true;
}

int VM_Version::max_vector_size(BasicType bt) {
return MaxVectorSize / type2aelembytes(bt);
}
3 changes: 3 additions & 0 deletions src/hotspot/cpu/s390/vm_version_s390.hpp
View file
Original file line number Diff line number Diff line change
@@ -567,6 +567,9 @@ class VM_Version: public Abstract_VM_Version {
static unsigned long z_SIGSEGV();

static void initialize_cpu_information(void);

// Max supported vector lane count for a particular lane type.
static int max_vector_size(BasicType bt);
};

#endif // CPU_S390_VM_VERSION_S390_HPP
2 changes: 2 additions & 0 deletions src/hotspot/cpu/zero/vm_version_zero.hpp
View file
Original file line number Diff line number Diff line change
@@ -36,6 +36,8 @@ class VM_Version : public Abstract_VM_Version {
constexpr static bool supports_stack_watermark_barrier() { return true; }

static void initialize_cpu_information(void);

static int max_vector_size(BasicType bt) { return -1;}
};

#endif // CPU_ZERO_VM_VERSION_ZERO_HPP
1 change: 1 addition & 0 deletions src/hotspot/share/classfile/vmSymbols.cpp
View file
Original file line number Diff line number Diff line change
@@ -185,6 +185,7 @@ const char* vmSymbols::name_for(vmSymbolID sid) {
}
#endif


void vmSymbols::symbols_do(SymbolClosure* f) {
for (auto index : EnumRange<vmSymbolID>{}) {
f->do_symbol(&Symbol::_vm_symbols[as_int(index)]);
3 changes: 3 additions & 0 deletions src/hotspot/share/oops/inlineKlass.cpp
View file
Original file line number Diff line number Diff line change
@@ -153,6 +153,9 @@ bool InlineKlass::flat_array() {
if (!UseFlatArray) {
return false;
}
if (VectorSupport::is_vector_payload_mf(this) || VectorSupport::is_vector(this)) {
return false;
}
Comment on lines +156 to +158
Copy link

@XiaohongGong XiaohongGong Oct 16, 2023 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiaohongGong, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user XiaohongGong" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sorry, something went wrong.

Copy link
Member Author

@jatin-bhateja jatin-bhateja Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array of vector may be heterogeneous in nature where each element points to a vector of different shape, thus array flatten do not make much sense to vectors. In additional during type resolution flat_array flag is set for imbalanced Phi (having different type of inputs e.g. VectorPayload64 and VectorPayload128) even though Phi's type is lower common ancestor type of participating inputs i.e., VectorPayload which itself is not an inlinetype, this leads to assertion failures in downstream flow.

https://github.com/openjdk/valhalla/blob/lworld/src/hotspot/share/opto/type.cpp#L4636

Instead of making a wider change in type resolution, where we flat_array setting also take into account exact type of PhiNode, I prefer to restrict array flatten for vectors.

Copy link

@XiaohongGong XiaohongGong Oct 16, 2023 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiaohongGong, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user XiaohongGong" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we never expose concrete vector types to users hence its only possible to create an array of abstract vector references which can be heterogeneous. This is different from an array of value types which are implicitly final classes and may be flattened into a compact layout since such an array will be homogeneous in nature.

Copy link

@XiaohongGong XiaohongGong Oct 17, 2023 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiaohongGong, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user XiaohongGong" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sorry, something went wrong.

Copy link
Member Author

@jatin-bhateja jatin-bhateja Oct 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! Seems it also causes the jvm crash in VectorXXXConversionTests, but I didn't figure out the root cause yet.

In this case PhiNode generated by PredictedCallGenerator based on the type profile was imbalanced i.e. its inputs had different concrete payload types, thus type of PhiNode got resolved to lowest common ancestor type i.e. an abstract vector payload type, in the downstream flow following assertion failed because flat_array flag for the type was set even though the type was a non-inline type.

https://github.com/openjdk/valhalla/blob/lworld/src/hotspot/share/opto/type.cpp#L4177

// Too big
int elem_bytes = get_exact_size_in_bytes();
if ((FlatArrayElementMaxSize >= 0) && (elem_bytes > FlatArrayElementMaxSize)) {
1 change: 0 additions & 1 deletion src/hotspot/share/prims/vectorSupport.hpp
View file
Original file line number Diff line number Diff line change
@@ -140,6 +140,5 @@ class VectorSupport : AllStatic {
static bool skip_value_scalarization(Klass* klass);
static int max_vector_size(BasicType bt);
static int get_max_multifield_count(const Symbol* payload_name);
static bool is_vector_payload(const Symbol* metadata);
};
#endif // SHARE_PRIMS_VECTORSUPPORT_HPP
34 changes: 14 additions & 20 deletions src/java.base/share/classes/jdk/internal/vm/vector/VectorSupport.java
View file
Original file line number Diff line number Diff line change
@@ -167,7 +167,7 @@ public abstract static class VectorPayloadMF {

@ForceInline
public static VectorPayloadMF newMaskInstanceFactory(Class<?> elemType, int length, boolean max_payload) {
if (false == max_payload) {
if (!max_payload) {
switch(length) {
case 1: return new VectorPayloadMF8Z();
case 2: return new VectorPayloadMF16Z();
@@ -183,23 +183,20 @@ public static VectorPayloadMF newMaskInstanceFactory(Class<?> elemType, int leng
return new VectorPayloadMFMaxBZ();
} else if (elemType == short.class) {
return new VectorPayloadMFMaxSZ();
} else if (elemType == int.class) {
} else if (elemType == int.class || elemType == float.class) {
return new VectorPayloadMFMaxIZ();
} else if (elemType == long.class) {
} else if (elemType == long.class || elemType == double.class) {
return new VectorPayloadMFMaxLZ();
} else if (elemType == float.class) {
return new VectorPayloadMFMaxIZ();
} else {
assert elemType == double.class;
return new VectorPayloadMFMaxLZ();
assert false : "Unexpected lane type";
}
}
return null;
}

@ForceInline
public static VectorPayloadMF newShuffleInstanceFactory(Class<?> elemType, int length, boolean max_payload) {
if (false == max_payload) {
if (!max_payload) {
switch(length) {
case 1: return new VectorPayloadMF8B();
case 2: return new VectorPayloadMF16B();
@@ -215,15 +212,12 @@ public static VectorPayloadMF newShuffleInstanceFactory(Class<?> elemType, int l
return new VectorPayloadMFMaxBB();
} else if (elemType == short.class) {
return new VectorPayloadMFMaxSB();
} else if (elemType == int.class) {
} else if (elemType == int.class || elemType == float.class) {
return new VectorPayloadMFMaxIB();
} else if (elemType == long.class) {
} else if (elemType == long.class || elemType == double.class) {
return new VectorPayloadMFMaxLB();
} else if (elemType == float.class) {
return new VectorPayloadMFMaxIB();
} else {
assert elemType == double.class;
return new VectorPayloadMFMaxLB();
assert false : "Unexpected lane type";
}
}
return null;
@@ -302,7 +296,7 @@ public static VectorPayloadMF newVectorInstanceFactory(Class<?> elemType, int le
}

@ForceInline
public static VectorPayloadMF createVectPayloadInstanceB(int length, byte [] init, boolean max_payload) {
public static VectorPayloadMF createVectPayloadInstanceB(int length, byte[] init, boolean max_payload) {
VectorPayloadMF obj = newVectorInstanceFactory(byte.class, length, max_payload);
obj = Unsafe.getUnsafe().makePrivateBuffer(obj);
long start_offset = obj.multiFieldOffset();
@@ -314,7 +308,7 @@ public static VectorPayloadMF createVectPayloadInstanceB(int length, byte [] ini
}

@ForceInline
public static VectorPayloadMF createVectPayloadInstanceS(int length, short [] init, boolean max_payload) {
public static VectorPayloadMF createVectPayloadInstanceS(int length, short[] init, boolean max_payload) {
VectorPayloadMF obj = newVectorInstanceFactory(short.class, length, max_payload);
obj = Unsafe.getUnsafe().makePrivateBuffer(obj);
long start_offset = obj.multiFieldOffset();
@@ -326,7 +320,7 @@ public static VectorPayloadMF createVectPayloadInstanceS(int length, short [] in
}

@ForceInline
public static VectorPayloadMF createVectPayloadInstanceI(int length, int [] init, boolean max_payload) {
public static VectorPayloadMF createVectPayloadInstanceI(int length, int[] init, boolean max_payload) {
VectorPayloadMF obj = newVectorInstanceFactory(int.class, length, max_payload);
obj = Unsafe.getUnsafe().makePrivateBuffer(obj);
long start_offset = obj.multiFieldOffset();
@@ -338,7 +332,7 @@ public static VectorPayloadMF createVectPayloadInstanceI(int length, int [] init
}

@ForceInline
public static VectorPayloadMF createVectPayloadInstanceL(int length, long [] init, boolean max_payload) {
public static VectorPayloadMF createVectPayloadInstanceL(int length, long[] init, boolean max_payload) {
VectorPayloadMF obj = newVectorInstanceFactory(long.class, length, max_payload);
obj = Unsafe.getUnsafe().makePrivateBuffer(obj);
long start_offset = obj.multiFieldOffset();
@@ -350,7 +344,7 @@ public static VectorPayloadMF createVectPayloadInstanceL(int length, long [] ini
}

@ForceInline
public static VectorPayloadMF createVectPayloadInstanceF(int length, float [] init, boolean max_payload) {
public static VectorPayloadMF createVectPayloadInstanceF(int length, float[] init, boolean max_payload) {
VectorPayloadMF obj = newVectorInstanceFactory(float.class, length, max_payload);
obj = Unsafe.getUnsafe().makePrivateBuffer(obj);
long start_offset = obj.multiFieldOffset();
@@ -362,7 +356,7 @@ public static VectorPayloadMF createVectPayloadInstanceF(int length, float [] in
}

@ForceInline
public static VectorPayloadMF createVectPayloadInstanceD(int length, double [] init, boolean max_payload) {
public static VectorPayloadMF createVectPayloadInstanceD(int length, double[] init, boolean max_payload) {
VectorPayloadMF obj = newVectorInstanceFactory(double.class, length, max_payload);
obj = Unsafe.getUnsafe().makePrivateBuffer(obj);
long start_offset = obj.multiFieldOffset();
16 changes: 9 additions & 7 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractMask.java
View file
Original file line number Diff line number Diff line change
@@ -41,23 +41,25 @@ abstract class AbstractMask<E> extends VectorMask<E> {
/*package-private*/
abstract VectorPayloadMF getBits();

static VectorPayloadMF prepare(VectorPayloadMF payload, int offset, Class<?> elementType, int length, boolean is_max_species) {
VectorPayloadMF res = VectorPayloadMF.newMaskInstanceFactory(elementType, length, is_max_species);
static <F> VectorPayloadMF prepare(VectorPayloadMF payload, int offset, VectorSpecies<F> species) {
boolean isMaxShape = species.vectorShape() == VectorShape.S_Max_BIT;
VectorPayloadMF res = VectorPayloadMF.newMaskInstanceFactory(species.elementType(), species.length(), isMaxShape);
res = Unsafe.getUnsafe().makePrivateBuffer(res);
long mOffset = res.multiFieldOffset();
for (int i = 0; i < length; i++) {
for (int i = 0; i < species.length(); i++) {
boolean b = Unsafe.getUnsafe().getBoolean(payload, mOffset + i + offset);
Unsafe.getUnsafe().putBoolean(res, mOffset + i, b);
}
res = Unsafe.getUnsafe().finishPrivateBuffer(res);
return res;
}

static VectorPayloadMF prepare(boolean val, Class<?> elementType, int length, boolean is_max_species) {
VectorPayloadMF res = VectorPayloadMF.newMaskInstanceFactory(elementType, length, is_max_species);
static <F> VectorPayloadMF prepare(boolean val, VectorSpecies<F> species) {
boolean isMaxShape = species.vectorShape() == VectorShape.S_Max_BIT;
VectorPayloadMF res = VectorPayloadMF.newMaskInstanceFactory(species.elementType(), species.length(), isMaxShape);
res = Unsafe.getUnsafe().makePrivateBuffer(res);
long mOffset = res.multiFieldOffset();
for (int i = 0; i < length; i++) {
for (int i = 0; i < species.length(); i++) {
Unsafe.getUnsafe().putBoolean(res, mOffset + i, val);
}
res = Unsafe.getUnsafe().finishPrivateBuffer(res);
@@ -138,7 +140,7 @@ public <F> VectorMask<F> cast(VectorSpecies<F> dsp) {
this.getClass(), vspecies().elementType(), vspecies().laneCount,
species.maskType(), species.elementType(), vspecies().laneCount,
this, species,
(m, s) -> s.maskFactory(m.getBits()).check(s));
(m, s) -> VectorMask.fromLong(s, m.toLong()).check(s));
Comment on lines -139 to +143
Copy link

@XiaohongGong XiaohongGong Oct 16, 2023 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiaohongGong, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user XiaohongGong" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sorry, something went wrong.

Copy link
Member Author

@jatin-bhateja jatin-bhateja Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot typecast value object with another value type, thus directly passing payload (m.getBits()) to maskFactory will cause runtime exceptions.

Copy link

@XiaohongGong XiaohongGong Oct 16, 2023 •
edited by bridgekeeper bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XiaohongGong, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user XiaohongGong" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Sorry, something went wrong.

}

@Override
12 changes: 8 additions & 4 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractShuffle.java
View file
Original file line number Diff line number Diff line change
@@ -39,8 +39,10 @@ abstract class AbstractShuffle<E> extends VectorShuffle<E> {
/*package-private*/
abstract VectorPayloadMF indices();

static VectorPayloadMF prepare(Class<?> elemType, int length, int[] indices, int offset, boolean is_max_species) {
VectorPayloadMF payload = VectorPayloadMF.newShuffleInstanceFactory(elemType, length, is_max_species);
static <F> VectorPayloadMF prepare(int[] indices, int offset, VectorSpecies<F> species) {
int length = species.length();
boolean isMaxShape = species.vectorShape() == VectorShape.S_Max_BIT;
VectorPayloadMF payload = VectorPayloadMF.newShuffleInstanceFactory(species.elementType(), length, isMaxShape);
payload = Unsafe.getUnsafe().makePrivateBuffer(payload);
long mf_offset = payload.multiFieldOffset();
for (int i = 0; i < length; i++) {
@@ -52,8 +54,10 @@ static VectorPayloadMF prepare(Class<?> elemType, int length, int[] indices, int
return payload;
}

static VectorPayloadMF prepare(Class<?> elemType, int length, IntUnaryOperator f, boolean is_max_species) {
VectorPayloadMF payload = VectorPayloadMF.newShuffleInstanceFactory(elemType, length, is_max_species);
static <F> VectorPayloadMF prepare(IntUnaryOperator f, VectorSpecies<F> species) {
int length = species.length();
boolean isMaxShape = species.vectorShape() == VectorShape.S_Max_BIT;
VectorPayloadMF payload = VectorPayloadMF.newShuffleInstanceFactory(species.elementType(), length, isMaxShape);
payload = Unsafe.getUnsafe().makePrivateBuffer(payload);
long offset = payload.multiFieldOffset();
for (int i = 0; i < length; i++) {
8 changes: 4 additions & 4 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte128Vector.java
View file
Original file line number Diff line number Diff line change
@@ -593,11 +593,11 @@ static final value class Byte128Mask extends AbstractMask<Byte> {
private final VectorPayloadMF128Z payload;

Byte128Mask(VectorPayloadMF payload, int offset) {
this(prepare(payload, offset, ETYPE, VLENGTH, false));
this(prepare(payload, offset, VSPECIES));
}

Byte128Mask(boolean val) {
this(prepare(val, ETYPE, VLENGTH, false));
this(prepare(val, VSPECIES));
}


@@ -769,11 +769,11 @@ static final value class Byte128Shuffle extends AbstractShuffle<Byte> {
}

public Byte128Shuffle(int[] indexes, int i) {
this(prepare(ETYPE, VLENGTH, indexes, i, false));
this(prepare(indexes, i, VSPECIES));
}

public Byte128Shuffle(IntUnaryOperator fn) {
this(prepare(ETYPE, VLENGTH, fn, false));
this(prepare(fn, VSPECIES));
}

public Byte128Shuffle(int[] indexes) {
8 changes: 4 additions & 4 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte256Vector.java
View file
Original file line number Diff line number Diff line change
@@ -625,11 +625,11 @@ static final value class Byte256Mask extends AbstractMask<Byte> {
private final VectorPayloadMF256Z payload;

Byte256Mask(VectorPayloadMF payload, int offset) {
this(prepare(payload, offset, ETYPE, VLENGTH, false));
this(prepare(payload, offset, VSPECIES));
}

Byte256Mask(boolean val) {
this(prepare(val, ETYPE, VLENGTH, false));
this(prepare(val, VSPECIES));
}


@@ -801,11 +801,11 @@ static final value class Byte256Shuffle extends AbstractShuffle<Byte> {
}

public Byte256Shuffle(int[] indexes, int i) {
this(prepare(ETYPE, VLENGTH, indexes, i, false));
this(prepare(indexes, i, VSPECIES));
}

public Byte256Shuffle(IntUnaryOperator fn) {
this(prepare(ETYPE, VLENGTH, fn, false));
this(prepare(fn, VSPECIES));
}

public Byte256Shuffle(int[] indexes) {
8 changes: 4 additions & 4 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Byte512Vector.java
View file
Original file line number Diff line number Diff line change
@@ -689,11 +689,11 @@ static final value class Byte512Mask extends AbstractMask<Byte> {
private final VectorPayloadMF512Z payload;

Byte512Mask(VectorPayloadMF payload, int offset) {
this(prepare(payload, offset, ETYPE, VLENGTH, false));
this(prepare(payload, offset, VSPECIES));
}

Byte512Mask(boolean val) {
this(prepare(val, ETYPE, VLENGTH, false));
this(prepare(val, VSPECIES));
}


@@ -865,11 +865,11 @@ static final value class Byte512Shuffle extends AbstractShuffle<Byte> {
}

public Byte512Shuffle(int[] indexes, int i) {
this(prepare(ETYPE, VLENGTH, indexes, i, false));
this(prepare(indexes, i, VSPECIES));
}

public Byte512Shuffle(IntUnaryOperator fn) {
this(prepare(ETYPE, VLENGTH, fn, false));
this(prepare(fn, VSPECIES));
}

public Byte512Shuffle(int[] indexes) {
Loading