Some HAT cleanups

[PaulSandoz]

• Fix hatrun.sh to use the correct paths (i think they are corrected, and verified for my local build)
• Enhance CMakeLists.txt to check if BEEHIVE env is set, so as not to hardcode the location
• Use more idiomatic code model APIs (some added based on HAT feedback)

---

Progress

• Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.org/babylon.git pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/141.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Some HAT cleanups

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (718eca47)
• 01: Full - Incremental (83013e50)
• 00: Full (ba7d9ea0)

[grfrost]

The hat run.bash file was set to execute maven targets If maven is run using mvn compile jar:jar install All the jars, libs and targets are placed in maven-build dir

…

On Fri, 14 Jun 2024 at 21:28, mlbridge[bot] ***@***.***> wrote: Webrevs - 00: Full <https://webrevs.openjdk.org/?repo=babylon&pr=141&range=00> (ba7d9ea <https://git.openjdk.org/babylon/pull/141/files/ba7d9ea04e58a80afe3abd8462d1493c9d458e10> ) — Reply to this email directly, view it on GitHub <#141 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBKEN7DVWGPC3T2TNLVEJTZHNG5XAVCNFSM6AAAAABJK6U646VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYG4YTQMBRGE> . You are receiving this because your review was requested.Message ID: ***@***.***>

[grfrost]

https://github.com/openjdk/babylon/blob/code-reflection/hat/README.md This doc explains the maven build process, and how to execute using hatrun.bash

…

On Fri, 14 Jun 2024 at 21:31, Gary Frost ***@***.***> wrote: The hat run.bash file was set to execute maven targets If maven is run using mvn compile jar:jar install All the jars, libs and targets are placed in maven-build dir On Fri, 14 Jun 2024 at 21:28, mlbridge[bot] ***@***.***> wrote: > Webrevs > > - 00: Full <https://webrevs.openjdk.org/?repo=babylon&pr=141&range=00> > (ba7d9ea > <https://git.openjdk.org/babylon/pull/141/files/ba7d9ea04e58a80afe3abd8462d1493c9d458e10> > ) > > — > Reply to this email directly, view it on GitHub > <#141 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABBKEN7DVWGPC3T2TNLVEJTZHNG5XAVCNFSM6AAAAABJK6U646VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYG4YTQMBRGE> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> >

[PaulSandoz]

On Jun 14, 2024, at 1:43 PM, grfrost ***@***.***> wrote: https://github.com/openjdk/babylon/blob/code-reflection/hat/README.md This doc explains the maven build process, and how to execute using hatrun.bash

Ah! Thanks, that explains it... somehow I missed it. I reverted changes to that script. Paul.

[grfrost]

/integrate

[openjdk]

@grfrost Only the author (@PaulSandoz) is allowed to issue the integrate command.

[grfrost]

Whoops I tried to integrate. But clearly that is not how this works. ;)

So I think this PR is ready to be integrated, but I think Paul has to initiate? Is that correct?

[PaulSandoz]

Whoops I tried to integrate. But clearly that is not how this works. ;)

So I think this PR is ready to be integrated, but I think Paul has to initiate? Is that correct?

Yes, only the submitter or sponsor (by default i presume) can integrate.

[PaulSandoz]

/integrate

[openjdk]

Going to push as commit 151840b.
Since your change was applied there have been 3 commits pushed to the code-reflection branch:

• 3a33038: Fixup babylon location property and remove spirv backend from default
• a70d3e9: Switching to maven build
• f21fef0: Removed heal and view examples - will return when working

Your commit was automatically rebased without conflicts.

[openjdk]

@PaulSandoz Pushed as commit 151840b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.