-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreachable switch expression block #260
Unreachable switch expression block #260
Conversation
👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into |
@PaulSandoz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@PaulSandoz Pushed as commit 24149a2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This fixes the generated code model for an unreachable edge case discussed in PR #257:
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/260/head:pull/260
$ git checkout pull/260
Update a local copy of the PR:
$ git checkout pull/260
$ git pull https://git.openjdk.org/babylon.git pull/260/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 260
View PR using the GUI difftool:
$ git pr show -t 260
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/260.diff
Webrev
Link to Webrev Comment