Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #300

Closed
wants to merge 2 commits into from
Closed

Conversation

mabbay
Copy link
Member

@mabbay mabbay commented Dec 19, 2024

This PR fixes typos introduced by #272.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.org/babylon.git pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/300.diff

Using Webrev

Link to Webrev Comment

@mabbay mabbay requested a review from PaulSandoz December 19, 2024 02:54
@mabbay mabbay self-assigned this Dec 19, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2024

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Fix typos

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the code-reflection branch:

  • 490332b: Hat bld and dir changes in prep for separating native ffi and jextracted backends
  • c0c70a4: Integrate Java Triton example with Intel Triton Backend
  • 79cd5cf: Revert change

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2024

Webrevs

…eOp.java

Co-authored-by: Paul Sandoz <paul.d.sandoz@googlemail.com>
@mabbay
Copy link
Member Author

mabbay commented Dec 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

Going to push as commit da874e8.
Since your change was applied there have been 3 commits pushed to the code-reflection branch:

  • 490332b: Hat bld and dir changes in prep for separating native ffi and jextracted backends
  • c0c70a4: Integrate Java Triton example with Intel Triton Backend
  • 79cd5cf: Revert change

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2024
@openjdk openjdk bot closed this Dec 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2024
@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@mabbay Pushed as commit da874e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mabbay mabbay deleted the reapply-lost-changes branch December 19, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants