-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code model from method reference #34
Code model from method reference #34
Conversation
👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into |
@PaulSandoz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
||
Executable resolveToMember(MethodHandles.Lookup l) throws ReflectiveOperationException; | ||
|
||
MethodHandle resolveToHandle(MethodHandles.Lookup l) throws ReflectiveOperationException; | ||
|
||
Optional<CoreOps.FuncOp> codeModel(MethodHandles.Lookup l) throws ReflectiveOperationException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the result is optional, do we also need the throws
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, an empty optional means the method that is referenced has no code model. If there is an error attempting to determine that or obtain the code model then an exception is thrown e.g., lookup does not have the appropriate permissions to access the code model.
/integrate |
Going to push as commit 8fcbeee. |
@PaulSandoz Pushed as commit 8fcbeee. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Obtain a code model from method reference. The implementation is simple and resolves the method reference to an instance of
Method
, and returns the result ofMethod::getCodeModel
.Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/34/head:pull/34
$ git checkout pull/34
Update a local copy of the PR:
$ git checkout pull/34
$ git pull https://git.openjdk.org/babylon.git pull/34/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 34
View PR using the GUI difftool:
$ git pr show -t 34
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/34.diff
Webrev
Link to Webrev Comment