Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExplicitOnnxOps.If implementation of captured values and initializers #359

Closed
wants to merge 8 commits into from

Conversation

asotona
Copy link
Member

@asotona asotona commented Mar 14, 2025

ExplicitOnnxOps.If implementation of captured values and initializers - another attempt to do it right

  • raw minimal support of variadic inputs and outputs
  • continuation work on If and Loop

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/359/head:pull/359
$ git checkout pull/359

Update a local copy of the PR:
$ git checkout pull/359
$ git pull https://git.openjdk.org/babylon.git pull/359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 359

View PR using the GUI difftool:
$ git pr show -t 359

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/359.diff

Using Webrev

Link to Webrev Comment

…f captured values and initializers
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2025

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

ExplicitOnnxOps.If implementation of captured values and initializers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the code-reflection branch:

  • 9c42d66: Hat replace bitfield min bufffer with state machine
  • 88441d8: Rearrange the source for better display.
  • 28179a6: updates demos for j1
  • a26f48c: Hat fix min buffer state machine
  • 5856c8d: Finalize switch to using hat subdir insteaf of bldr subdir
  • a3bd45c: We are switching to use hat subdir (instead of bldr) for scripts

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

asotona added 2 commits March 15, 2025 02:14
@asotona asotona marked this pull request as ready for review March 15, 2025 01:19
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2025

Webrevs

@asotona
Copy link
Member Author

asotona commented Mar 24, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

Going to push as commit 15fa02f.
Since your change was applied there have been 6 commits pushed to the code-reflection branch:

  • 9c42d66: Hat replace bitfield min bufffer with state machine
  • 88441d8: Rearrange the source for better display.
  • 28179a6: updates demos for j1
  • a26f48c: Hat fix min buffer state machine
  • 5856c8d: Finalize switch to using hat subdir insteaf of bldr subdir
  • a3bd45c: We are switching to use hat subdir (instead of bldr) for scripts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2025
@openjdk openjdk bot closed this Mar 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@asotona Pushed as commit 15fa02f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant