Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A transformer of code models to models that build them. #37

Closed

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Mar 11, 2024

A building code model when executed will construct the same code model it was transformed from. Such a building code model could be transformed to bytecode and stored in class files. This may be a better cross platform alternative than storing the textual form in class files (the form of which would need to be specified).

The implementation is using the operation factory and type factory to construct operations and types from their more general definitions (similarly to how they are used by the parser).

It would be interesting to compare the size of class files with the embedded textual form of a code model and the generated bytecode to build the code model. We could be more efficient but the implementation cost is not worth it, at least for now and would require further evaluation of that cost.


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.org/babylon.git pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/37.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2024

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@PaulSandoz PaulSandoz marked this pull request as ready for review March 12, 2024 16:35
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

A transformer of code models to models that build them.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 12, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

@PaulSandoz
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

Going to push as commit 638ba1f.
Since your change was applied there has been 1 commit pushed to the code-reflection branch:

  • 90df3aa: Assertion Interpreter Implementation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2024
@openjdk openjdk bot closed this Mar 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2024
@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@PaulSandoz Pushed as commit 638ba1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@PaulSandoz PaulSandoz deleted the op-func-builder branch March 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

1 participant