-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify use of (rel)-pool values #134
Conversation
…s, but can be used for fix versions
👋 Welcome back calnan! A progress list of the required criteria for merging this PR into |
@calnan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @JesperIRL) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks
/integrate |
/sponsor |
@JesperIRL @calnan Pushed as commit 2f922b4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
(rel)-pool values should not be used for affects versions, but can, along with tbd, be used in the fix version
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/134/head:pull/134
$ git checkout pull/134
Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.org/guide.git pull/134/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 134
View PR using the GUI difftool:
$ git pr show -t 134
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/guide/pull/134.diff
Webrev
Link to Webrev Comment