Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of (rel)-pool values #134

Closed
wants to merge 3 commits into from
Closed

Conversation

calnan
Copy link
Contributor

@calnan calnan commented Aug 12, 2024

(rel)-pool values should not be used for affects versions, but can, along with tbd, be used in the fix version


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.org/guide.git pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/guide/pull/134.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

…s, but can be used for fix versions
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

👋 Welcome back calnan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@calnan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Clarify use of (rel)-pool values

Reviewed-by: iris, dholmes, jwilhelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@irisclark, @JesperIRL) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Aug 12, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

⚠️ @calnan the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout pool-value-use
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready label Aug 12, 2024
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks

@calnan
Copy link
Contributor Author

calnan commented Sep 30, 2024

/integrate

@openjdk openjdk bot added the sponsor label Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@calnan
Your change (at version 5a2c6ca) is now ready to be sponsored by a Committer.

@JesperIRL
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

Going to push as commit 2f922b4.
Since your change was applied there has been 1 commit pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@JesperIRL @calnan Pushed as commit 2f922b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calnan calnan deleted the pool-value-use branch February 26, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants