Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor #12181

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 25, 2023

Issue seems to be very old, very intermittent bug which is not reproducible in repeated test run,
so added some stability fixes like accessing swing components in EDT, delay, frame dispose and take a screenshot during fail.
Multiple runs on CI platforms is ok.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12181/head:pull/12181
$ git checkout pull/12181

Update a local copy of the PR:
$ git checkout pull/12181
$ git pull https://git.openjdk.org/jdk.git pull/12181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12181

View PR using the GUI difftool:
$ git pr show -t 12181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12181.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 25, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 25, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299713: Test javax/swing/JTableHeader/6889007/bug6889007.java failed: Wrong type of cursor

Reviewed-by: serb, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1332 new commits pushed to the master branch:

  • b062b1b: 8304743: Compile_lock and SystemDictionary updates
  • df819cf: 8304945: StringBuilder and StringBuffer should implement Appendable explicitly
  • 312bbe7: 8305485: Problemlist runtime/Thread/TestAlwaysPreTouchStacks.java
  • 50e31e0: 8305442: (bf) Direct and view implementations of CharBuffer.toString(int, int) do not need to catch SIOBE
  • 85e3974: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to junit
  • 40aea04: 8278268: (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets
  • 9b9b5a7: 8302323: Add repeat methods to StringBuilder/StringBuffer
  • dd7ca75: 8305478: [REDO] disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
  • f9827ad: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897
  • 6010de0: 8305417: disable gtest/NMTGtests.java sub-tests failing due to JDK-8305414
  • ... and 1322 more: https://git.openjdk.org/jdk/compare/ce6395a1356a3d1334aeffc70ac8e4f86dd81a4c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2023
@kumarabhi006
Copy link
Contributor

@prsadhuk Trying to run the test in ubuntu system, it ended with time out error. Test passed in windows system.

@TejeshR13
Copy link
Contributor

@prsadhuk Trying to run the test in ubuntu system, it ended with time out error. Test passed in windows system.

@kumarabhi006 I'm not getting any such error in ubuntu. Fix is working for me in windows and ubuntu.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2023

@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@prsadhuk
Copy link
Contributor Author

time

@prsadhuk
Copy link
Contributor Author

prsadhuk commented May 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented May 1, 2023

Going to push as commit b54c4a3.
Since your change was applied there have been 1690 commits pushed to the master branch:

  • b3dbf28: 8292275: javac does not emit SYNTHETIC and MANDATED flags for parameters by default
  • 6d6d00b: 8306954: Open source five Focus related tests
  • bb7608b: 8307088: Allow the jdbc.drivers system property to be searchable
  • a2d3fc8: 8304837: Classfile API throws IOOBE for MethodParameters attribute without parameter names
  • d43a5a2: 8307135: java/awt/dnd/NotReallySerializableTest/NotReallySerializableTest.java failed
  • 1f68924: 8306955: Open source several JComboBox jtreg tests
  • b8de394: 8307080: Open source some more JComboBox jtreg tests
  • 4818c79: 8307110: zero build broken after JDK-8304265
  • da9efee: 8296935: Arrays.asList() can return a List that throws undocumented ArrayStoreException
  • 05af487: 8306681: Open source more AWT DnD related tests
  • ... and 1680 more: https://git.openjdk.org/jdk/compare/ce6395a1356a3d1334aeffc70ac8e4f86dd81a4c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 1, 2023
@openjdk openjdk bot closed this May 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 1, 2023
@openjdk
Copy link

openjdk bot commented May 1, 2023

@prsadhuk Pushed as commit b54c4a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8299713 branch May 1, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

4 participants