Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302267: [jittester] Improve separation of test generation and execution #12527

Closed
wants to merge 3 commits into from

Conversation

lepestock
Copy link
Contributor

@lepestock lepestock commented Feb 13, 2023

Please review a set of improvements that should improve working with other fuzzing generators and usage of JitTesterDriver with tests generated not by the JITTester:

  • Provide better separation of individual test generation from java file writing, compiling, executing, etc.;
  • Introduce distinct Phases of the generation process (Generation, Compilation, GoldRun and VerificationRun);
  • Extract JItTesterDriver headers generation so that it would be possible to provide other header generators;
  • Introduce error tolerance to not get distracted by OOMEs, intrinsics missing in the compiled code, etc.;
  • Make it possible to specify time limit for an individual test generation;
  • Give better control over temp/workdir creation and cleaning;
  • Unify external process running;
  • Introduce UTF-8 support in external processes' output and human-readable escaping of it;

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302267: [jittester] Improve separation of test generation and execution

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12527/head:pull/12527
$ git checkout pull/12527

Update a local copy of the PR:
$ git checkout pull/12527
$ git pull https://git.openjdk.org/jdk.git pull/12527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12527

View PR using the GUI difftool:
$ git pr show -t 12527

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12527.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2023

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 13, 2023

@lepestock The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-compiler hotspot-compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Feb 13, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 13, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 23, 2023

@lepestock this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8302267/pub
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Feb 23, 2023
StringBuilder sb = new StringBuilder();

src.chars().forEachOrdered(code -> {
if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) {
if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) {

private final Builder builder;

public static class Builder {
private Function<String, String[]> preRunActions = s -> new String[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private Function<String, String[]> preRunActions = s -> new String[0];
private Function<String, String[]> preRunActions = s -> new String[0];

this.builder = builder;
}

public String getJtregHeader(String mainClassName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public String getJtregHeader(String mainClassName) {
public String getJtregHeader(String mainClassName) {

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2023

@lepestock This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 3, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2023

@lepestock This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org merge-conflict Pull request has merge conflict with target branch
3 participants