New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8302267: [jittester] Improve separation of test generation and execution #12527
Conversation
👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into |
@lepestock The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@lepestock this pull request can not be integrated into git checkout JDK-8302267/pub
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
StringBuilder sb = new StringBuilder(); | ||
|
||
src.chars().forEachOrdered(code -> { | ||
if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) { | |
if ((code >= 32) && (code <= 126) && (code != 92) || (code == 9)) { |
private final Builder builder; | ||
|
||
public static class Builder { | ||
private Function<String, String[]> preRunActions = s -> new String[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private Function<String, String[]> preRunActions = s -> new String[0]; | |
private Function<String, String[]> preRunActions = s -> new String[0]; |
this.builder = builder; | ||
} | ||
|
||
public String getJtregHeader(String mainClassName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public String getJtregHeader(String mainClassName) { | |
public String getJtregHeader(String mainClassName) { |
@lepestock This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@lepestock This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Please review a set of improvements that should improve working with other fuzzing generators and usage of JitTesterDriver with tests generated not by the JITTester:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12527/head:pull/12527
$ git checkout pull/12527
Update a local copy of the PR:
$ git checkout pull/12527
$ git pull https://git.openjdk.org/jdk.git pull/12527/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12527
View PR using the GUI difftool:
$ git pr show -t 12527
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12527.diff
Webrev
Link to Webrev Comment