8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea

[quantum6]

Candidat box can moving with caret on windows version. Someone must wrote codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes. Why it doesn't work, is the key problem.

1, I wrote a example for linux:
https://github.com/quantum6/X11InputMethod

I tried all parameters to test and as my research:
If you use XIMPreeditCallbacks to initiate, the box can't be moved with caret.
If you use XIMPreeditNothing, it works.
All examples use XIMPreeditCallbacks to initiate input method and candidate box can't moving. So I understand why he didn't commit the codes.

2, I traced the route of transfering caret coordites on windows version, then add codes for linux.
3, Taishan Office(like Microsoft Office Word) is running on jdk, we tested for a long time, it works OK.
4, I am not sure for AIX( no environment).

JDK-8264728 : When use chinese IME, the candidate box isn't moved with caret of JTextArea
Type: Bug
Component: client-libs
Sub-Component: java.awt:i18n
Affected Version: 8,9,15,16
Priority: P3
Status: Open
Resolution: Unresolved
OS: linux
CPU: x86_64

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13055/head:pull/13055
$ git checkout pull/13055

Update a local copy of the PR:
$ git checkout pull/13055
$ git pull https://git.openjdk.org/jdk.git pull/13055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13055

View PR using the GUI difftool:
$ git pr show -t 13055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13055.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back quantum6! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@quantum6 The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 09: Full - Incremental (df6c7628)
• 08: Full - Incremental (97450047)
• 07: Full - Incremental (882a939f)
• 06: Full - Incremental (e7608861)
• 05: Full - Incremental (5bb8fd5a)
• 04: Full - Incremental (6c9015b0)
• 03: Full - Incremental (284ddbf7)
• 02: Full - Incremental (b576bcf8)
• 01: Full - Incremental (7338c7e5)
• 00: Full (d30095ff)

[openjdk]

@quantum6 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[quantum6]

I am sorry for rebase. Shall I close the PR and create a new one?
Thanks.

[prrace]

Provide a complete description and explanation of what you are doing, and why it is is the correct solution and
what testing you have done and what testing you have NOT done and what the risks are - including to apps not using an IM
In other words, whilst you (I hope) understand how you decided this was the right solution (and weren't just copying
what someone proposed in the bug report), reviewers would like to hear from YOU. Not just see code.
So spend time writing it up properly and clearly.

[quantum6]

Provide a complete description and explanation of what you are doing.

Thanks, I have add a description. In fact it isn't a complex problem, the key problem is how to initinate. If have any problem, please notify me.,
Good luck!

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[quantum6]

There are several bugs same to this. I hope this code can be integrated ASAP.
Good luck!

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[quantum6]

Is there anyone to check this?

[Jisu-Woniu]

This issue also affects JetBrains IDE and many other Java GUI apps on Linux, so I hope you can merge it ASAP.

[quantum6]

This issue also affects JetBrains IDE and many other Java GUI apps on Linux, so I hope you can merge it ASAP.

Thanks. I also hope so!

[quantum6]

Hello! Is there someone review this?

[quantum6]

Who can review this? Or can I ask someone to review?

[Jisu-Woniu]

@prrace Is there anyone we can ask for help?

[quantum6]

@prrace This bug exists in all jdk version, like jdk8,jdk11,jdk17. I hope the codes can be integrated ASAP, then I will create PR for jdk8/jdk11/jdk17. So can you ask someone to review and integrate this PR?
Thanks.

[NikitkoCent]

Hi, guys! I want to notice that JetBrains is working on the issue too and we're going to propose our own fix.

[quantum6]

@NikitkoCent It's a good news. If you find any problem, you can try this example:
https://github.com/quantum6/X11InputMethod

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[quantum6]

Hello!

[Jisu-Woniu]

Any updates?

[quantum6]

Any updates?

Waiting for anyone to integrate...

[senluowx]

Hi, guys! I want to notice that JetBrains is working on the issue too and we're going to propose our own fix.

This problem has existed for more than ten years, do you guys have time to plan

[Jisu-Woniu]

Community patch[1][2] has been around for a long time, but no official fix has applied.

[NikitkoCent]

@prrace, hello!
OMG, I didn't know that the review comments don't appear until you press the "Submit review" button. I left them a few months ago and thought that just nobody cared.

About the plans: I'm going to release a preview build of our JVM (JBR) with the patch solving this problem in a few weeks, polish it according to the feedback and then propose the patch to OpenJDK.

[Jisu-Woniu]

Why this check failed? How to configure it? I researched and have no idea. Can anyone help me?

Pre-submit tests - linux-x86 / test - Test (tier1) Failing after 64m — 1/10 failed

Seems like that it failed to get the source bundle. Maybe restarting could work.

[quantum6]

Hello! Can anyone review the code? Thanks.

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[quantum6]

Hello! Is there anyone to review thic ?

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[quantum6]

hello

[prrace]

Please read the comments further up, @NikitkoCent wants to propose an alternative fix.
Having said that, we've been waiting on that a long time now, so I hope it shows up soon.

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@quantum6 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[quantum6]

I am back now. Who can check and merge this code?

[SeaCodeBase]

Hi @SeaCodeBase, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user SeaCodeBase" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[openjdk]

@SeaCodeBase Only the pull request author can set the pull request state to "open"

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[prrace]

@quantum6 - See all the messages in the log above.
YOU need to issue the "/open" command before any one can re-review this.

But whatever happened to @NikitkoCent ? He said he had an alternative.
@NikitkoCent please speak up or ..

[quantum6]

/open

[openjdk]

@quantum6 This pull request is now open