New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8305118: Add RISC-V related content to building.md #13223
Conversation
👋 Welcome back gli! A progress list of the required criteria for merging this PR into |
Webrevs
|
RISC-V cross-compiles with sysroots fine: Sometimes you need to point to tools like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some formatting and grammar notes. I can help you with running pandoc later.
Thanks for the tips. I know why I failed locally now. The mirror path should be |
Generated html file here https://github.com/erikj79/jdk/commits/pull/13223 |
Thanks. |
@lgxbslgx This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 151 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ce6e746.
Your commit was automatically rebased without conflicts. |
Hi all,
This patch adds the RISC-V related content to
building.md
. But I didn'tgenerate
building.html
locally, because I know thepandoc
versionmay influencethe the output of
building.html
(Need help here).I know there are many steps and subtle points about cross-compiling the
external libraries. Considering the content length and the libraries are
introduced at
External Library Requirements
, I give only one exampleinstead of all of them.
And I tried to build it by using
devkits
andDebian sysroots
. But it failed locally.Maybe someone who has built successfully can tell me how to change the
document, which mainly adds the right name to their supported target table.
Thanks for the review and assist.
Best Regards,
-- Guoxiong
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13223/head:pull/13223
$ git checkout pull/13223
Update a local copy of the PR:
$ git checkout pull/13223
$ git pull https://git.openjdk.org/jdk.git pull/13223/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13223
View PR using the GUI difftool:
$ git pr show -t 13223
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13223.diff
Webrev
Link to Webrev Comment