Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8305118: Add RISC-V related content to building.md #13223

Closed
wants to merge 6 commits into from

Conversation

lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Mar 29, 2023

Hi all,

This patch adds the RISC-V related content to building.md. But I didn't
generate building.html locally, because I know the pandoc version
may influencethe the output of building.html (Need help here).

I know there are many steps and subtle points about cross-compiling the
external libraries. Considering the content length and the libraries are
introduced at External Library Requirements, I give only one example
instead of all of them.

And I tried to build it by using devkits and Debian sysroots. But it failed locally.
Maybe someone who has built successfully can tell me how to change the
document, which mainly adds the right name to their supported target table.

Thanks for the review and assist.

Best Regards,
-- Guoxiong


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305118: Add RISC-V related content to building.md

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13223/head:pull/13223
$ git checkout pull/13223

Update a local copy of the PR:
$ git checkout pull/13223
$ git pull https://git.openjdk.org/jdk.git pull/13223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13223

View PR using the GUI difftool:
$ git pr show -t 13223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13223.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2023

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 29, 2023
@openjdk
Copy link

openjdk bot commented Mar 29, 2023

@lgxbslgx The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 29, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2023

Webrevs

@shipilev
Copy link
Member

RISC-V cross-compiles with sysroots fine:
https://builds.shipilev.net/openjdk-jdk/configure-logs/configure-openjdk-jdk-linux-riscv64-server-release-gcc10-glibc2.31.log
https://builds.shipilev.net/openjdk-jdk/build-logs/build-openjdk-jdk-linux-riscv64-server-release-gcc10-glibc2.31.log

Sometimes you need to point to tools like OBJCOPY and STRIP, if the host/target triplets contain unknown. But other than that, it should be pretty straight-forward.

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting and grammar notes. I can help you with running pandoc later.

doc/building.md Outdated Show resolved Hide resolved
doc/building.md Outdated Show resolved Hide resolved
@lgxbslgx
Copy link
Member Author

RISC-V cross-compiles with sysroots fine: https://builds.shipilev.net/openjdk-jdk/configure-logs/configure-openjdk-jdk-linux-riscv64-server-release-gcc10-glibc2.31.log https://builds.shipilev.net/openjdk-jdk/build-logs/build-openjdk-jdk-linux-riscv64-server-release-gcc10-glibc2.31.log

Sometimes you need to point to tools like OBJCOPY and STRIP, if the host/target triplets contain unknown. But other than that, it should be pretty straight-forward.

Thanks for the tips. I know why I failed locally now. The mirror path should be debian-ports instead of debian. http://deb.debian.org/debian-ports and http://httpredir.debian.org/debian-ports succeed. The file .github/workflows/build-cross-compile.yml provides the concrete information.

doc/building.md Outdated Show resolved Hide resolved
@erikj79
Copy link
Member

erikj79 commented Apr 5, 2023

Generated html file here https://github.com/erikj79/jdk/commits/pull/13223

@lgxbslgx
Copy link
Member Author

lgxbslgx commented Apr 5, 2023

Generated html file here https://github.com/erikj79/jdk/commits/pull/13223

Thanks.

@openjdk
Copy link

openjdk bot commented Apr 5, 2023

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305118: Add RISC-V related content to building.md

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 151 new commits pushed to the master branch:

  • 2e59d21: 8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads
  • f69d88c: 8301616: Drag & maximize to another monitor places window incorrectly (Windows)
  • a3137c7: 8305646: compile error on Alpine with gcc12 after 8298619 in libGetXSpace.c
  • 78ff454: 8305490: CommandProcessor command "dumpclass" produces classes with invalid field descriptors
  • 9f587d2: 8305644: IGV: Node text not updated when switching from/to CFG view
  • 4bf1987: 8296454: System.console() shouldn't return null in jshell
  • 2aec910: 8304883: Record Deconstruction causes bytecode error
  • 0e0c022: 8305356: Fix ignored bad CompileCommands in tests
  • b659c35: 8068824: Exception thrown in JTableHeader after clicking on popupmenu opened with right-click on header
  • 83a924a: 8304042: C2 SuperWord: schedule must remove packs with cyclic dependencies
  • ... and 141 more: https://git.openjdk.org/jdk/compare/765a94258d84ac6f22bb2dedd1fc1afdbabb2b14...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 5, 2023
@lgxbslgx
Copy link
Member Author

lgxbslgx commented Apr 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2023

Going to push as commit ce6e746.
Since your change was applied there have been 174 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2023
@openjdk openjdk bot closed this Apr 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2023
@openjdk
Copy link

openjdk bot commented Apr 7, 2023

@lgxbslgx Pushed as commit ce6e746.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lgxbslgx lgxbslgx deleted the JDK-8305118 branch April 7, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
4 participants