JDK-8305414: gtest/NMTGtests.java is failing various sub-tests

[tstuefe]

With JDK-8304815 we started to use NMT - if enabled - for better hs-err reporting by asking it to make sense out of otherwise unknown memory locations.

If the location points into or nearby a C-heap block, we now see that. That even works for dead blocks (use after free). For details, see JDK-8304815 and the comments in mallocTracker.cpp.

The change came with its own gtest, which promptly started to fail on some platforms. The reason was an error in MallocTracker::print_pointer_information() that caused us to prematurely return from its search-loop if we encounter unmapped memory. Never happened in my tests, but of course depends on where libc places the test blocks, which makes this error intermittent.

Patch fixes that, and also fixes some debug output in the test.

Tests: Ran the test manually on Linux aarch64; was able to reproduce the errors without patch, no errors with patch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305414: gtest/NMTGtests.java is failing various sub-tests

Reviewers

• Roman Kennke (@rkennke - Reviewer) ⚠️ Review applies to 613d38a4
• Andrew Dinn (@adinn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13296/head:pull/13296
$ git checkout pull/13296

Update a local copy of the PR:
$ git checkout pull/13296
$ git pull https://git.openjdk.org/jdk.git pull/13296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13296

View PR using the GUI difftool:
$ git pr show -t 13296

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13296.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (68ea5b74)
• 04: Full - Incremental (613d38a4)
• 03: Full - Incremental (775014c0)
• 02: Full - Incremental (9afe9227)
• 01: Full - Incremental (45065588)
• 00: Full (6ea66291)

[rkennke]

Looks good to me. Thanks!

[tstuefe]

Looks good to me. Thanks!

Thank you for the quick review!

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305414: gtest/NMTGtests.java is failing various sub-tests

Reviewed-by: rkennke, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

• e846a1d: 8304450: [vectorapi] Refactor VectorShuffle implementation
• 3f36dd8: 8305529: DefaultProxySelector.select(URI) in certain cases returns a List with null element
• 425ef06: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries
• 2bbbff2: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
• bc15163: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[])
• 19380d7: 8305324: C2: Wrong execution of vectorizing Interger.reverseBytes
• 87017b5: 8295859: Update Manual Test Groups
• 99a9dbc: 8305783: x86_64: Optimize AbsI and AbsL
• d8af7a6: 8304725: AsyncGetCallTrace can cause SIGBUS on M1
• b9bdbe9: 8305524: AArch64: Fix arraycopy issue on SVE caused by matching rule vmask_gen_sub
• ... and 72 more: https://git.openjdk.org/jdk/compare/83a924a1008853dee2ead8f6c3a82f9e3abc6125...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Pinging @jdksjolen ...

[tstuefe]

Friendly ping

[dcubed-ojdk]

@tstuefe - I'm running Mach5 testing on v04. Will keep you posted:

• Tier1 - no failures
• Tier2 - no failures
• Tier3 - 1 known, unrelated test failure (client test)
• Tier4 - no failures
• Tier5 - 8 known, unrelated test failures
• Tier6 - no failures

I'm done with the Mach5 testing. Looks good to me.

[adinn]

Looks good to me to.

[tstuefe]

Thank you @adinn . Thanks to @dcubed-ojdk for testing.

/integrate

[openjdk]

Going to push as commit fb9a29d.
Since your change was applied there have been 82 commits pushed to the master branch:

• e846a1d: 8304450: [vectorapi] Refactor VectorShuffle implementation
• 3f36dd8: 8305529: DefaultProxySelector.select(URI) in certain cases returns a List with null element
• 425ef06: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries
• 2bbbff2: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries
• bc15163: 8304834: Fix wrapper insertion in TestScaffold.parseArgs(String args[])
• 19380d7: 8305324: C2: Wrong execution of vectorizing Interger.reverseBytes
• 87017b5: 8295859: Update Manual Test Groups
• 99a9dbc: 8305783: x86_64: Optimize AbsI and AbsL
• d8af7a6: 8304725: AsyncGetCallTrace can cause SIGBUS on M1
• b9bdbe9: 8305524: AArch64: Fix arraycopy issue on SVE caused by matching rule vmask_gen_sub
• ... and 72 more: https://git.openjdk.org/jdk/compare/83a924a1008853dee2ead8f6c3a82f9e3abc6125...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit fb9a29d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.