-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8305620: Missing break
in DocCommentParser inlineWord()
#13343
JDK-8305620: Missing break
in DocCommentParser inlineWord()
#13343
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 022290b.
Your commit was automatically rebased without conflicts. |
@jonathan-gibbons Pushed as commit 022290b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a fix for the
depth
counting inDocCommentParser
inlineWord
.There was a missing break that caused the count to go high, and because of that the code for the down count needed to be adjusted as well.
The test is modified to be stylistically more like the others with
abc
anddef
surrounding the{@index...}
tag. This looks like it may have been a typo, and helped hide the counting issue.Progress
Issue
break
in DocCommentParserinlineWord()
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13343/head:pull/13343
$ git checkout pull/13343
Update a local copy of the PR:
$ git checkout pull/13343
$ git pull https://git.openjdk.org/jdk.git pull/13343/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13343
View PR using the GUI difftool:
$ git pr show -t 13343
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13343.diff
Webrev
Link to Webrev Comment