Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306638: Open source some AWT tests related to datatransfer and Toolkit #13642

Closed
wants to merge 2 commits into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 25, 2023

This PR open sources some tests related to AWT datatransfer and Toolkit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8306638: Open source some AWT tests related to datatransfer and Toolkit

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13642/head:pull/13642
$ git checkout pull/13642

Update a local copy of the PR:
$ git checkout pull/13642
$ git pull https://git.openjdk.org/jdk.git pull/13642/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13642

View PR using the GUI difftool:
$ git pr show -t 13642

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13642.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2023

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2023
@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@jayathirthrao The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 25, 2023
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 25, 2023

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306638: Open source some AWT tests related to datatransfer and Toolkit

Reviewed-by: prr, serb, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 371 new commits pushed to the master branch:

  • 7b0b9b5: 8308049: Refactor nested class declarations in FdLibm.java
  • cc80ada: 8306593: Fix nsk/jdi/stop/stop001 for virtual threads and remove from problem list
  • 43c8c65: 8307555: Reduce memory reads in x86 MD5 intrinsic
  • 01892f9: 8304913: Use OperatingSystem, Architecture, and Version in jlink
  • 0f7b1c5: 8299340: CreateProcessW lpCommandLine must be mutable
  • 57e7a3f: 8307959: Remove explicit type casts from SerializeClosure::do_xxx() calls
  • 97b2ca3: 8307997: gtest:ZIndexDistributorTest fails on PPC64
  • ffab1ea: 8308086: GHA: x86_32 host configuration failing with unmet dependencies
  • ad348a8: 8303512: Race condition when computing is_loaded property of TypePtr::InterfaceSet
  • 911cc7c: 8305819: LogConfigurationTest intermittently fails on AArch64
  • ... and 361 more: https://git.openjdk.org/jdk/compare/36ec05d52a79185d8c6669713fd17933128c032a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2023
@jayathirthrao
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2023

Going to push as commit 2210e06.
Since your change was applied there have been 373 commits pushed to the master branch:

  • 05b51c7: 8307567: Avoid relocating global roots to metaspaceObjs in CDS dump
  • 3168372: 8306597: Improve string formatting in EquivMapsGenerator.java
  • 7b0b9b5: 8308049: Refactor nested class declarations in FdLibm.java
  • cc80ada: 8306593: Fix nsk/jdi/stop/stop001 for virtual threads and remove from problem list
  • 43c8c65: 8307555: Reduce memory reads in x86 MD5 intrinsic
  • 01892f9: 8304913: Use OperatingSystem, Architecture, and Version in jlink
  • 0f7b1c5: 8299340: CreateProcessW lpCommandLine must be mutable
  • 57e7a3f: 8307959: Remove explicit type casts from SerializeClosure::do_xxx() calls
  • 97b2ca3: 8307997: gtest:ZIndexDistributorTest fails on PPC64
  • ffab1ea: 8308086: GHA: x86_32 host configuration failing with unmet dependencies
  • ... and 363 more: https://git.openjdk.org/jdk/compare/36ec05d52a79185d8c6669713fd17933128c032a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2023
@openjdk openjdk bot closed this May 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

@jayathirthrao Pushed as commit 2210e06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8306638 branch May 16, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants