Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8307301: Update HarfBuzz to 7.2.0 #13835

Closed
wants to merge 4 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented May 5, 2023

Harfbuzz updated from 7.0.1 to 7.2.0.

Files changed -

  • harfbuzz.md file updated
  • 1 newly added source file - hb-ot-var-cvar-table.hh
  • 73 modified source files

Following testing was carried for the update and works as expected.

  1. Client CI Testing
  2. TextLayout related tests
  3. Font2DTest in TextLayout mode
  4. Manual Testing of Arabic, Hebrew, Thai, Indic languages on TextLayout. (Mac, Windows and Linux)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13835/head:pull/13835
$ git checkout pull/13835

Update a local copy of the PR:
$ git checkout pull/13835
$ git pull https://git.openjdk.org/jdk.git pull/13835/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13835

View PR using the GUI difftool:
$ git pr show -t 13835

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13835.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented May 5, 2023

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 5, 2023

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 5, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label May 5, 2023
@mlbridge
Copy link

mlbridge bot commented May 5, 2023

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented May 5, 2023

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307301: Update HarfBuzz to 7.2.0

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

  • b5a4827: 8306871: Open source more AWT Drag & Drop tests
  • 47422be: 8307375: Alignment check on layouts used as sequence element is not correct
  • 3968ab5: 8307395: Add missing STS to Shenandoah
  • 12d6ec6: 8307236: Rendezvous GC threads under STS for monitor deflation
  • 6fe959c: 8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at
  • 3f6a354: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
  • f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
  • 746f8d1: 8305714: Add an extra test for JDK-8292755
  • 1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
  • 3b430b9: 8250596: Update remaining manpage references from "OS X" to "macOS"
  • ... and 58 more: https://git.openjdk.org/jdk/compare/561ec9c5a06e5baeb0cf72463d14d1d720facb13...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2023
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2023

Going to push as commit d8b230c.
Since your change was applied there have been 68 commits pushed to the master branch:

  • b5a4827: 8306871: Open source more AWT Drag & Drop tests
  • 47422be: 8307375: Alignment check on layouts used as sequence element is not correct
  • 3968ab5: 8307395: Add missing STS to Shenandoah
  • 12d6ec6: 8307236: Rendezvous GC threads under STS for monitor deflation
  • 6fe959c: 8307306: Change some ConstantPool::name_ref_at calls to uncached_name_ref_at
  • 3f6a354: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
  • f143bf7: 8305084: Remove the removal warnings for finalize() from test/hotspot/jtreg/serviceability/dcmd/gc/FinalizerInfoTest.java and RunFinalizationTest.java
  • 746f8d1: 8305714: Add an extra test for JDK-8292755
  • 1a1ce66: 8305080: Suppress the 'removal' warning for finalize() from test/hotspot/jtreg/compiler/jvmci/common/testcases that used in compiler/jvmci/compilerToVM/ tests
  • 3b430b9: 8250596: Update remaining manpage references from "OS X" to "macOS"
  • ... and 58 more: https://git.openjdk.org/jdk/compare/561ec9c5a06e5baeb0cf72463d14d1d720facb13...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2023
@openjdk openjdk bot closed this May 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 5, 2023
@openjdk
Copy link

openjdk bot commented May 5, 2023

@honkar-jdk Pushed as commit d8b230c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants