8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake()

[jaikiran]

Can I please get a review of this change in the jdk.httpclient.test.lib.http2.Http2TestServerConnection which proposes to use the SSLSocket.startHandshake() to API propogate any handshake exception back to the test that uses this test server?

This addresses https://bugs.openjdk.org/browse/JDK-8308185 and as noted in that JBS issue should help diagnoze any handshake failures in httpclient tests, a bit more easily.

tier2 testing with this change came back without any failures.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake()

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14012/head:pull/14012
$ git checkout pull/14012

Update a local copy of the PR:
$ git checkout pull/14012
$ git pull https://git.openjdk.org/jdk.git pull/14012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14012

View PR using the GUI difftool:
$ git pr show -t 14012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14012.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ce9c402a)

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308185: Update Http2TestServerConnection to use SSLSocket.startHandshake()

Reviewed-by: djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 316bc79: 8308188: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC on all platforms
• 8686a36: 8307315: Missing ResourceMark in CDS and JVMTI code
• 23cbb2d: 8306860: Avoid unnecessary allocation in List.map() when list is empty
• be54b54: 8307369: Add execution of all svc tests in CI
• 19c8c30: 8305634: Renaming predicates, simple cleanups, and adding summary about current predicates

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Thank you Daniel for the review.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 1a6f981.
Since your change was applied there have been 21 commits pushed to the master branch:

• b300e73: 8308088: Improve class check in CollectedHeap::is_oop
• e34ecc9: 8296469: Instrument VMError::report with reentrant iteration step for register and stack printing
• 5a92aae: 8308156: VerifyCACerts.java misses blank in error output
• 2f1c654: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• d3e5065: 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive
• 563152f: 8308223: failure handler missed jcmd.vm.info command
• cb8b8cd: 8307458: Add periodic heap usage JFR events
• f9a785e: 8307547: Support variant collations
• 4e92991: 8300794: Use @snippet in java.util:i18n
• 64d5157: 8306467: Fix nsk/jdb/kill/kill001 to work with new JVMTI StopThread support for virtual threads.
• ... and 11 more: https://git.openjdk.org/jdk/compare/72294c5402dd11e3eb4922ad26e1b153098495ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 1a6f981.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.