JDK-8308040 Evaluate new public types in non-public classes

[JimLaskey]

As reported by Marc Hoffman of javaalmanac.io, in a recent JDK 21 build there are new public types nested in non-public interfaces:

java.lang.runtime.ReferenceKey.SoftKey
java.lang.runtime.ReferenceKey.StrongKey
java.lang.runtime.ReferenceKey.WeakKey
java.util.Digits.DecimalDigits
java.util.Digits.HexDigits
java.util.Digits.OctalDigits

This PR moves the nested classes to neighbouring package private classes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308040: Evaluate new public types in non-public classes

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14039/head:pull/14039
$ git checkout pull/14039

Update a local copy of the PR:
$ git checkout pull/14039
$ git pull https://git.openjdk.org/jdk.git pull/14039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14039

View PR using the GUI difftool:
$ git pr show -t 14039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14039.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[RogerRiggs]

Looks good, a straight-forward rename/move of nested classes to package-private classes implementing a package-private interface.

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308040: Evaluate new public types in non-public classes

Reviewed-by: rriggs, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 108 new commits pushed to the master branch:

• ac89e30: 8308291: compiler/jvmci/meta/ProfilingInfoTest.java fails with -XX:TieredStopAtLevel=1
• bacf652: 8297887: Update Siphash
• 89f2d45: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames
• d10467e: 8307738: JFR: EventStream.openRepository() drops events
• 736b90d: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
• 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
• d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
• 544978c: 8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out
• 65c8dbe: 8171221: Remove -XX:+CheckMemoryInitialization
• 2d4d850: 8308091: Remove unused iRegIHeapbase() matching operand
• ... and 98 more: https://git.openjdk.org/jdk/compare/8bedf2efd7671834b3f7ff42bc33008821545d9f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (67fbb365)

[JimLaskey]

/integrate

[openjdk]

Going to push as commit b44fa36.
Since your change was applied there have been 108 commits pushed to the master branch:

• ac89e30: 8308291: compiler/jvmci/meta/ProfilingInfoTest.java fails with -XX:TieredStopAtLevel=1
• bacf652: 8297887: Update Siphash
• 89f2d45: 8308237: add JDWP and JDI virtual thread support for ThreadReference.PopFrames
• d10467e: 8307738: JFR: EventStream.openRepository() drops events
• 736b90d: 8308310: HttpClient: Avoid logging or locking from within synchronized blocks
• 7764f46: 8308761: New test TestHFA needs adaptation for JDK-8308276
• d7245f7: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions
• 544978c: 8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out
• 65c8dbe: 8171221: Remove -XX:+CheckMemoryInitialization
• 2d4d850: 8308091: Remove unused iRegIHeapbase() matching operand
• ... and 98 more: https://git.openjdk.org/jdk/compare/8bedf2efd7671834b3f7ff42bc33008821545d9f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JimLaskey Pushed as commit b44fa36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.