8308090: Add container tests for on-the-fly resource quota updates

[jerboaa]

Please review these test changes which implement automatic testing of container resource updates without JVM restart. Note that this merely tests container detection code handling this case. It doesn't do anything special for the JVM itself, though it might make sense to add some sanity checks should we detect certain limits changing. In another PR, though.

As to the test design, it works similar to the shared temp tests: Interact between the two containers by virtue of a shared filesystem /tmp and creating marker files there in order to make them cooperate. Note that the new test needs podman version 4.3.0 and better (4.5 is current).

Testing:

• GHA
• Linux x86_64 container tests on cg v1 and cg v2 system
• Newly added tests on Linux x86_64 cg v1 and cg v2 (podman and docker)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308090: Add container tests for on-the-fly resource quota updates

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Mikhailo Seledtsov (@mseledts - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14090/head:pull/14090
$ git checkout pull/14090

Update a local copy of the PR:
$ git checkout pull/14090
$ git pull https://git.openjdk.org/jdk.git pull/14090/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14090

View PR using the GUI difftool:
$ git pr show -t 14090

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14090.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8cca3671)
• 00: Full (761f410e)

[jerboaa]

Anyone willing to review this?

[dholmes-ora]

@jerboaa I can't really review the tests themselves but will run through our CI to see if they cause any problems. If not then they should be okay to add.

[dholmes-ora]

These tests didn't fail but I couldn't properly validate the output as we don't seem to save the process stdout file.

But I guess these are okay.

Thanks.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308090: Add container tests for on-the-fly resource quota updates

Reviewed-by: dholmes, mseledtsov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 157 new commits pushed to the master branch:

• 101bf22: 8308891: TestCDSVMCrash.java needs @requires vm.cds
• 2bb1972: 8308954: [JVMCI] code installation increments decompile_count for call_site_target_value failures
• 0ab0963: 8308469: [PPC64] Implement alternative fast-locking scheme
• ec55539: 8309138: Fix container tests for jdks with symlinked conf dir
• e827164: 8309146: extend JDI StackFrame.setValue() and JDWP StackFrame.setValues minimal support for virtual threads
• be36096: 8302822: Method/Field/Constructor/RecordComponent::getGenericInfo() is not thread safe
• c6f20db: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
• d987176: 8307794: Test for HSS/LMS Signature Verification
• 050425b: 8298127: HSS/LMS Signature Verification
• a6109bf: 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem
• ... and 147 more: https://git.openjdk.org/jdk/compare/4f0f77618731003010198e2163c9f3f53892a64f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Thanks @dholmes-ora for running them through your CI.

[mseledts]

Changes look good to me. Thank you for adding these tests.

[jerboaa]

Thanks for the review!

[jerboaa]

/integrate

[openjdk]

Going to push as commit dc8bc6c.
Since your change was applied there have been 166 commits pushed to the master branch:

• 73e7af9: 8309287: Add fontconfig requirement to building.md for Debian
• aeb53e6: 8308711: Develop additional Tests for KEM implementation
• dcd9590: 8309224: Fix xlc17 clang 15 warnings in java.desktop
• 8f1ce78: 8308752: Generational ZGC: Avoid final marking through stack chunks
• 7b0a336: 8308387: CLD created and unloading list sharing _next node pointer leads to concurrent YC missing CLD roots
• 60f3b87: 8309295: C2: MaxNode::signed_min() returns nullptr for int operands
• 8007599: 8309093: Underscore with brackets
• 5bd2af2: 8307478: Implementation of Prepare to Restrict The Dynamic Loading of Agents
• 325940b: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows
• 101bf22: 8308891: TestCDSVMCrash.java needs @requires vm.cds
• ... and 156 more: https://git.openjdk.org/jdk/compare/4f0f77618731003010198e2163c9f3f53892a64f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit dc8bc6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.