8308842: Consolidate exceptions thrown from Class-File API

[asotona]

Class-File API actually throws wide variety of exceptions based on the actual situation. Complete error handling code must cover IndexOutOfBoundsException, IllegalStateException and IllegalArgumentException.

Based on previous discussions we decided to consolidate on IllegalArgumentException with possible sub-classes.

It allows easy common error handling in majority of use case, however it allows also to distinguish source of the error when needed (for example javap needs to know if the exception comes from constant poll or not).

Newly introduced ConstantPoolException extends IllegalArgumentException to indicate the source of the problem is in constant pool.

Please review.

Thanks,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308842: Consolidate exceptions thrown from Class-File API

Reviewers

• Brian Goetz (@briangoetz - Reviewer) ⚠️ Review applies to 65a7e70a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14143/head:pull/14143
$ git checkout pull/14143

Update a local copy of the PR:
$ git checkout pull/14143
$ git pull https://git.openjdk.org/jdk.git pull/14143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14143

View PR using the GUI difftool:
$ git pr show -t 14143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14143.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (2454c8e2)
• 03: Full - Incremental (36d29858)
• 02: Full - Incremental (65a7e70a)
• 01: Full - Incremental (8bc444df)
• 00: Full (d2ec1c99)

[liach]

What other types of exceptions does javap distinguish, and should Classfile API distinguish them as well?

[asotona]

What other types of exceptions does javap distinguish, and should Classfile API distinguish them as well?

Invalid CP index or content are cases where javap tries to recover, replace the value with '???' and print the rest.
This PR is extracted Classfile API - related part of #11411

[liach]

Then this should suffice for now. We can create specific subtypes if we wish to expose specific exceptions in the future.

[briangoetz]

Exception classes in the JDK generally have four constructors: (), (Throwable), (String), and (String, Throwable).

[asotona]

I'll add missing constructors, thanks.

[briangoetz]

Reviewed, only minor comment is the one about constructors in the new exception class.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308842: Consolidate exceptions thrown from Class-File API

Reviewed-by: briangoetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 2b38343: 8309416: Misstatement in semantics of methods in javax.lang.model.ElementFilter
• 73352b6: 8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction
• 5cd8af7: 8308726: RISC-V: avoid unnecessary slli in the vectorized arraycopy stubs for bytes
• 80232b7: 8308969: make test-prebuilt doesn't return the correct exit code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[asotona]

/integrate

[openjdk]

Going to push as commit 4b8922f.
Since your change was applied there have been 4 commits pushed to the master branch:

• 2b38343: 8309416: Misstatement in semantics of methods in javax.lang.model.ElementFilter
• 73352b6: 8280994: [XWayland] Drag and Drop does not work in java -> wayland app direction
• 5cd8af7: 8308726: RISC-V: avoid unnecessary slli in the vectorized arraycopy stubs for bytes
• 80232b7: 8308969: make test-prebuilt doesn't return the correct exit code

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 4b8922f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.