8308589: gc/cslocker/TestCSLocker.java timed out

[stefank]

We have found that this test is flawed and will cause deadlocks if allocations wait for a GC to complete. We tried to fix this issue by removing one source of allocations (see JDK-8308043), but that there are still more reasons why the JVM might allocate memory in the test. The test has a history of causing timeouts (likely caused by deadlocks), but we're currently only seeing hangs with Generational ZGC. I propose that we turn off this test for Generational ZGC, and if the test still cause problems in other configurations then we'll reevaluate if this should be handled some other way.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308589: gc/cslocker/TestCSLocker.java timed out

Reviewers

• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14150/head:pull/14150
$ git checkout pull/14150

Update a local copy of the PR:
$ git checkout pull/14150
$ git pull https://git.openjdk.org/jdk.git pull/14150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14150

View PR using the GUI difftool:
$ git pr show -t 14150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14150.diff

Webrev

Link to Webrev Comment

[stefank]

/label add hotspot-gc

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 00: Full (6bb43798)

[fisk]

Looks good.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308589: gc/cslocker/TestCSLocker.java timed out

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 48d21bd: 8286597: Implement PollerProvider on AIX
• e7edf8d: 8300038: Make new version of JNU_GetStringPlatformChars which checks for null characters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[stefank]

/integrate

[openjdk]

Going to push as commit cc0976b.
Since your change was applied there have been 20 commits pushed to the master branch:

• 17ef8a4: 8299665: /proc/self/stat parsing in libmanagement broken by execname with spaces
• c494770: 8306812: Open source several AWT Miscellaneous tests
• d3b9b36: 8308009: Generational ZGC: OOM before clearing all SoftReferences
• bac02b6: 8305189: C2 failed "assert(_outcnt==1) failed: not unique"
• 62537d2: 8299974: Replace NULL with nullptr in share/adlc/
• f09345b: 8308931: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
• 7c072db: 8308844: ProblemList gc/z/TestHighUsage.java with Generational ZGC on windows x64
• 4becb7b: 8306137: Open source several AWT ScrollPane related tests
• 199b1bf: 8308583: SIGSEGV in GraphKit::gen_checkcast
• 46c4da7: 8159023: Engineering notation of DecimalFormat does not work as documented
• ... and 10 more: https://git.openjdk.org/jdk/compare/90e57fd5a96199b01e7c058a4d8a82e467d7f41a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank Pushed as commit cc0976b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.