Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308943: jdk.internal.le build fails on AIX #14176

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented May 26, 2023

Build of jdk.internal.le fails on AIX, because code in the unix directory expects jdk.internal.org.jline.terminal.impl.jna.JDKNativePty for each platform (unix-like), but it does not for AIX.

We could add a stub of this class into the aix directory (methods could throw an exception, which would automatically switch JLine into the "external executable" mode, if enabled). But, it might be better to use the ServiceLoader, and simply register a platform-specific provider as a service. This patch is attempting to do the latter.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14176/head:pull/14176
$ git checkout pull/14176

Update a local copy of the PR:
$ git checkout pull/14176
$ git pull https://git.openjdk.org/jdk.git pull/14176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14176

View PR using the GUI difftool:
$ git pr show -t 14176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14176.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2023

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 26, 2023
@openjdk
Copy link

openjdk bot commented May 26, 2023

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label May 26, 2023
@mlbridge
Copy link

mlbridge bot commented May 26, 2023

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented May 30, 2023

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308943: jdk.internal.le build fails on AIX

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 78aac24: 8308881: Strong CLD oop handle roots are demoted to non-roots concurrently
  • 1f1f604: 8302670: use-after-free related to PhaseIterGVN interaction with Unique_Node_List and Node_Stack
  • d35a550: 8309077: Problemlist compiler/jvmci/TestUncaughtErrorInCompileMethod.java
  • 457e1cb: 8308817: RISC-V: Support VectorTest node for Vector API
  • 7508d9f: 8308906: Make CIPrintCompilerName a diagnostic flag
  • a4bae3a: 8309060: Compilation Error in javax/swing/event/FocusEventCauseTest.java
  • d73fc70: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • 7cf6eec: 8307488: Incorrect weight of the first ObjectAllocationSample JFR event
  • a5d8d59: 8308930: [JVMCI] TestUncaughtErrorInCompileMethod times out
  • 70130d3: 8306119: Many components respond to a mouse event by requesting focus without supplying the MOUSE_EVENT cause
  • ... and 26 more: https://git.openjdk.org/jdk/compare/27ba8bd4edf0c6f6d747579534262c223047a645...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2023
@lahodaj
Copy link
Contributor Author

lahodaj commented Jun 1, 2023

In the end, I've used a simpler version that was done under #14247. Thanks for the review/efforts anyway!

@lahodaj lahodaj closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kulla kulla-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants