8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use #14177

DarraghClarke · 2023-05-26T12:57:59Z

HttpURLConnectionExpectContinueTest was throwing an error due to port being hardcoded, updated test to let the system decide which port to use.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use (Bug - P4)

Reviewers

Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14177/head:pull/14177
$ git checkout pull/14177

Update a local copy of the PR:
$ git checkout pull/14177
$ git pull https://git.openjdk.org/jdk.git pull/14177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14177

View PR using the GUI difftool:
$ git pr show -t 14177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14177.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-05-26T12:58:43Z

👋 Welcome back DarraghClarke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-05-26T13:00:42Z

@DarraghClarke The following label will be automatically applied to this pull request:

net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-05-26T13:05:07Z

Webrevs

dfuch · 2023-05-26T13:34:08Z

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java

@@ -73,7 +73,7 @@ public void startServerSocket() throws Exception {

        control.serverSocket = new ServerSocket();
        control.serverSocket.setReuseAddress(true);
-        control.serverSocket.bind(new InetSocketAddress("127.0.0.1", 54321));
+        control.serverSocket.bind(new InetSocketAddress("127.0.0.1", 0));


While you're at it can you change the address to use InetAddress.getLoopbackAddress()here, and the URIBuilder in createConnection() below?

based on Daniel's last comment and requested change then I think it would be useful to add two additional run requests to the test which set the network properties java.net.preferIPv4Stack=true and java.net.preferIPv6Addresses=true, for completeness.
You never know what might "pop out of the woodwork"

I added those changes and verified that the tests are still passing

msheppar · 2023-06-08T14:25:20Z

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java

+    private HttpURLConnection createConnection() throws Exception {
+        URL url = URIBuilder.newBuilder()
+                .scheme("http")
+                .host(InetAddress.getLoopbackAddress())


This will change the call flow of the test in a slightly subtle way. In the original the "host" is supplied i.e. localhost which should map to the loopback address, and in the change the loopback IP address is being supplied diectly. In terms of equivalence then supplying a host string might be more appropriate:
.host("localhost")

No that's precisely what we want to avoid. Because how "localhost" maps to an InetAddress depends on the machine configuration, which is a recipe for intermittent failures.

I'd suggest:

URL url = URIBuilder.newBuilder() .scheme("http") .localhost()

(which is actually the same)

At a glance there isn't a .localhost() only a .loopback() is that what you were referring to?

Yes! Sorry - my mistake.

I pushed that change now and am currently rerunning tests

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java

…tinueTest.java Co-authored-by: Daniel Fuchs <67001856+dfuch@users.noreply.github.com>

dfuch

LGTM.

openjdk · 2023-06-08T16:50:19Z

@DarraghClarke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 258 new commits pushed to the master branch:

dc842e8: 8309665: Simplify Arrays.copyOf/-Range methods
3070856: 8309702: Exclude java/lang/ScopedValue/StressStackOverflow.java from JTREG_TEST_THREAD_FACTORY=Virtual runs
97df6cf: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status
f91e9ba: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
0a697e7: 8307620: [IR Framework] Readme mentions JTREG_WHITE_LIST_FLAGS instead of JTREG_WHITELIST_FLAGS
6f492e8: 8309686: inconsistent URL for https://www.unicode.org/reports/tr35
c4e6542: 8309675: Generational ZGC: compiler/gcbarriers/UnsafeIntrinsicsTest.java fails in nmt_commit
34f0a6e: 8305593: Add @SPEC tags in java.desktop
0be3905: 8309595: Allow javadoc to process unnamed classes
b2a5271: 8309196: Remove Thread.countStackFrames
... and 248 more: https://git.openjdk.org/jdk/compare/2d4d850813235a7533cd3bbf776adf69f90f02e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

DarraghClarke · 2023-06-09T12:19:37Z

Spent some time double checking tests and everything seems to be stable

DarraghClarke · 2023-06-09T12:20:20Z

/integrate

openjdk · 2023-06-09T12:20:43Z

@DarraghClarke
Your change (at version 9dd40a4) is now ready to be sponsored by a Committer.

dfuch · 2023-06-09T14:05:24Z

/sponsor

openjdk · 2023-06-09T14:06:03Z

Going to push as commit a48bcf3.
Since your change was applied there have been 259 commits pushed to the master branch:

c052756: 8282797: CompileCommand parsing errors should exit VM
dc842e8: 8309665: Simplify Arrays.copyOf/-Range methods
3070856: 8309702: Exclude java/lang/ScopedValue/StressStackOverflow.java from JTREG_TEST_THREAD_FACTORY=Virtual runs
97df6cf: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status
f91e9ba: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING
0a697e7: 8307620: [IR Framework] Readme mentions JTREG_WHITE_LIST_FLAGS instead of JTREG_WHITELIST_FLAGS
6f492e8: 8309686: inconsistent URL for https://www.unicode.org/reports/tr35
c4e6542: 8309675: Generational ZGC: compiler/gcbarriers/UnsafeIntrinsicsTest.java fails in nmt_commit
34f0a6e: 8305593: Add @SPEC tags in java.desktop
0be3905: 8309595: Allow javadoc to process unnamed classes
... and 249 more: https://git.openjdk.org/jdk/compare/2d4d850813235a7533cd3bbf776adf69f90f02e6...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-06-09T14:06:19Z

@dfuch @DarraghClarke Pushed as commit a48bcf3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

change test to use ephemeral port

be625cf

openjdk bot added the rfr Pull request is ready for review label May 26, 2023

openjdk bot added the net net-dev@openjdk.org label May 26, 2023

dfuch reviewed May 26, 2023

View reviewed changes

implemented feedback

49b77cb

msheppar reviewed Jun 8, 2023

View reviewed changes

dfuch reviewed Jun 8, 2023

View reviewed changes

test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java Outdated Show resolved Hide resolved

DarraghClarke and others added 2 commits June 8, 2023 16:48

Update test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectCon…

272c871

…tinueTest.java Co-authored-by: Daniel Fuchs <67001856+dfuch@users.noreply.github.com>

use loopback

9dd40a4

dfuch approved these changes Jun 8, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 8, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 9, 2023

openjdk bot added the integrated Pull request has been integrated label Jun 9, 2023

openjdk bot closed this Jun 9, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use #14177

8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use #14177

DarraghClarke commented May 26, 2023 •

edited by openjdk bot

bridgekeeper bot commented May 26, 2023

openjdk bot commented May 26, 2023

mlbridge bot commented May 26, 2023 •

edited

dfuch May 26, 2023

msheppar Jun 7, 2023

DarraghClarke Jun 8, 2023

msheppar Jun 8, 2023

dfuch Jun 8, 2023

DarraghClarke Jun 8, 2023

dfuch Jun 8, 2023

DarraghClarke Jun 8, 2023

dfuch left a comment

openjdk bot commented Jun 8, 2023 •

edited

DarraghClarke commented Jun 9, 2023

DarraghClarke commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

dfuch commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use #14177

8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use #14177

Conversation

DarraghClarke commented May 26, 2023 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented May 26, 2023

openjdk bot commented May 26, 2023

mlbridge bot commented May 26, 2023 • edited

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfuch left a comment

Choose a reason for hiding this comment

openjdk bot commented Jun 8, 2023 • edited

DarraghClarke commented Jun 9, 2023

DarraghClarke commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

dfuch commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

openjdk bot commented Jun 9, 2023

DarraghClarke commented May 26, 2023 •

edited by openjdk bot

mlbridge bot commented May 26, 2023 •

edited

openjdk bot commented Jun 8, 2023 •

edited