-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8308987: Update java.lang.Class to use javadoc snippets #14194
Conversation
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
Webrevs
|
* {@code Class t = Class.forName("java.lang.Thread")} | ||
* </blockquote> | ||
* {@snippet lang="java" : | ||
* Class<?> t = Class.forName("java.lang.Thread") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a final semicolon, as it's already a variable declaration and initialization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure; will fix in next push. Thanks.
* </blockquote> | ||
* {@snippet lang="java" : | ||
* Class.forName("Foo", true, this.getClass().getClassLoader()) | ||
* } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important but there are at least 3 different indentation widths in the update. Does it look okay in the generated javadoc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous blockquote tag normalized the space -- adjusted the leading whitespace to be consistent.
@jddarcy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 1b8e6bf.
Your commit was automatically rebased without conflicts. |
Straightforward doc refactoring to use snippets.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14194/head:pull/14194
$ git checkout pull/14194
Update a local copy of the PR:
$ git checkout pull/14194
$ git pull https://git.openjdk.org/jdk.git pull/14194/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14194
View PR using the GUI difftool:
$ git pr show -t 14194
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14194.diff
Webrev
Link to Webrev Comment